Add a initializer to Google_Protobuf_Timestamp with rounding control #1748
+213
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Provide a new initializer with explicit rounding controls and map the other initializer though the single code paths. Deprecate the old apis to direct folks to the new one to acknowledge the rounding that is happening on their values.
thomasvl
commented
Jan 23, 2025
| /// - imeIntervalSince1970: The `TimeInterval`, interpreted as | ||
| /// seconds relative to 00:00:00 UTC on 1 January 1970. | ||
| /// - rule: The rounding rule to use. | ||
| public init( |
There was a problem hiding this comment.
@allevato and I were discussion options here, and this seems to follow things like Date in that it includes time interval in the name. Other things we considered:
init(
roundingSince1970 timeInterval: TimeInterval,
rule: FloatingPointRoundingRule
)Which provides a slightly shorter name than what is suggested here.
init(
timeIntervalSince1970: TimeInterval,
roundingRule: FloatingPointRoundingRule
)Would mean we don't have to deprecate the current method for the default rounding, but the naming of the rule argument is slightly different than foundation apis.
There was a problem hiding this comment.
@FranzBusch @tbkka @Lukasa any thoughts on the naming choices here?
There was a problem hiding this comment.
I do quite like the new name, honestly.
allevato
approved these changes
Jan 23, 2025
Sources/SwiftProtobuf/Google_Protobuf_Timestamp+Extensions.swift
Outdated
Show resolved
Hide resolved
Rephrase comments Co-authored-by: Tony Allevato <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide a new initializer with explicit rounding controls and map the other initializer though the single code paths.
Deprecate the old apis to direct folks to the new one to acknowledge the rounding that is happening on their values.