[cmake] Install libraries in standard directories #213
+29
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, libs were installed under `lib/swift/${os}`. They should be
installed in the default library directory for the relevant target
system.
In addition, swiftmodules were installed in the older layout format.
This changes to use the standard modern layout format for swiftmodules.
Steelskin
requested review from
glessard,
lorentey and
milseman
as code owners
|
@swift-ci please test |
|
@swift-ci please test macOS platform |
|
Note: will wait to merge until we get a nightly that incorporates the equivalent patch to argument parser. |
FYI, this landed in apple/swift-argument-parser#685 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, libs were installed under
lib/swift/${os}. They should be installed in the default library directory for the relevant target system.In addition, swiftmodules were installed in the older layout format. This changes to use the standard modern layout format for swiftmodules.