refactor: refactor Android FCM integration and update dependencies #767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace `apikey` with `credential` for Android configuration - Update tests to reflect the change from `apikey` to `credential` - Update dependencies in `go.mod`, including upgrading `go-fcm` and adding new Firebase and Google Cloud libraries - Modify FCM client initialization to use credentials JSON data - Refactor notification structure to use `firebase.google.com/go/v4/messaging` instead of `github.com/appleboy/go-fcm` - Remove unused `TimeToLive`, `CollapseKey`, `RestrictedPackageName`, and `DryRun` fields from Android notifications - Adjust logging and error handling to align with new FCM client responses - Update topic handling in notifications to use `Topic` instead of `To` - Remove redundant checks and simplify notification validation logic Signed-off-by: appleboy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
apikeywithcredentialfor Android configurationapikeytocredentialgo.mod, including upgradinggo-fcmand adding new Firebase and Google Cloud librariesfirebase.google.com/go/v4/messaginginstead ofgithub.com/appleboy/go-fcmTimeToLive,CollapseKey,RestrictedPackageName, andDryRunfields from Android notificationsTopicinstead ofToref : #550