-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preview post-processing stage changes in appleseed.studio #2885
Draft
laurelkeys
wants to merge
13
commits into
appleseedhq:master
Choose a base branch
from
laurelkeys:fxs/reload
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Franz and I just tested your PR. Amazing work ! We are concerned about the processing time taken by the bloom effect or other future resource-intensive effect. I think we already discussed about this, but maybe you can add a checkbox to control the preview ? Like the following : That checkbox won't be visible when first adding the effect, as the preview doesn't work there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a rendered preview when parameter values are changed for post-processing stages (similar to the current behavior of
False Colors
).Note that only the effect that is being changed is applied for preview (i.e. if there are multiple stages, this won't show all of them).
Obs.: as of right now, when you add a new effect it doesn't work untill you click
OK
to add it and then edit its parameters. This should be fixed before this PR is merged.Other "nice-to-have"s are: