Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump com.approvaltests:approvaltests from 24.14.2 to 24.16.0 #146

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Feb 4, 2025

Bumps com.approvaltests:approvaltests from 24.14.2 to 24.16.0.

Release notes

Sourced from com.approvaltests:approvaltests's releases.

Allow configuration of project base directory

By default, Approvals uses the working directory to find the working directory and its children to find source file and store received and approved files. This is now configurable if your working directory no longer contains the source. You can do this by setting either the system property or system environment variable called APPROVALTESTS_PROJECT_DIRECTORY. Here is an example of doing this when running tests with maven on forks:

<systemPropertyVariables>
    <APPROVALTESTS_PROJECT_DIRECTORY>${project.basedir}</APPROVALTESTS_PROJECT_DIRECTORY>
</systemPropertyVariables>

Reported in #608

Also fixes #612

Add Once object like in Golang

Once.run(() -> ... your code here ...) Will execute that code once and only once.

Commits
  • 35fe4a1 . d updated markdown snippets
  • 8ad1652 ! F allow configuration of project base directory
  • 870a0f2 ! B catch exception on DNS error, closes #612
  • dc488f4 Bump com.google.code.gson:gson from 2.12.0 to 2.12.1
  • 4302db1 v 24.15.0
  • 404823a - r Refactor to use Once
  • 06870d1 . B Remove bug where Once would fire multiple times if the lambda had fields
  • 5a4a01c . F Create Once like in Golang
  • 159cd2a . r Moving internal .logging
  • 2ee6077 Bump com.google.code.gson:gson from 2.11.0 to 2.12.0
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Summary by Sourcery

Update com.approvaltests:approvaltests from 24.14.2 to 24.16.0.

Enhancements:

  • Allow configuration of project base directory using the APPROVALTESTS_PROJECT_DIRECTORY environment variable.
  • Add a Once object to execute code once and only once.

Bumps [com.approvaltests:approvaltests](https://github.com/approvals/ApprovalTests.Java) from 24.14.2 to 24.16.0.
- [Release notes](https://github.com/approvals/ApprovalTests.Java/releases)
- [Commits](approvals/ApprovalTests.Java@24.14.2...24.16.0)

---
updated-dependencies:
- dependency-name: com.approvaltests:approvaltests
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file java Pull requests that update Java code labels Feb 4, 2025
Copy link

sourcery-ai bot commented Feb 4, 2025

Reviewer's Guide by Sourcery

This pull request bumps the com.approvaltests:approvaltests dependency from version 24.14.2 to 24.16.0. This includes a new feature that allows configuration of the project base directory, and a new Once object, similar to the one in Golang.

Sequence diagram for project base directory configuration

sequenceDiagram
    participant ApprovalTests
    participant System
    participant FileSystem
    ApprovalTests->>System: Check APPROVALTESTS_PROJECT_DIRECTORY
    alt Property exists
        System-->>ApprovalTests: Return configured directory
        ApprovalTests->>FileSystem: Use configured directory for files
    else Property not set
        System-->>ApprovalTests: Return null
        ApprovalTests->>FileSystem: Use working directory for files
    end
Loading

Class diagram for the new Once utility class

classDiagram
    class Once {
        +run(Runnable action) void$
    }
    note for Once "New utility class that ensures
code runs exactly once"
Loading

File-Level Changes

Change Details Files
Updated the approvaltests dependency to the latest version.
  • Updated the version of the approvaltests dependency from 24.14.2 to 24.16.0
pom.xml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have skipped reviewing this pull request. Here's why:

  • It seems to have been created by a bot (hey, dependabot[bot]!). We assume it knows what it's doing!
  • We don't review packaging changes - Let us know if you'd like us to change this.

@isidore isidore merged commit a96f01b into master Feb 4, 2025
7 checks passed
@dependabot dependabot bot deleted the dependabot/maven/com.approvaltests-approvaltests-24.16.0 branch February 4, 2025 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file java Pull requests that update Java code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant