Update ace chart cleaner job (#541)

- Rename ace check job to cleaner - Delete both successful and failed ace jobs Signed-off-by: Tamal Saha <[email protected]>
appscode-cloud · Oct 25, 2024 · c4f7fc5 · c4f7fc5
1 parent 7282974
commit c4f7fc5
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 9 deletions.
diff --git a/charts/ace/templates/check/job.yaml → charts/ace/templates/cleaner/job.yaml b/charts/ace/templates/check/job.yaml → charts/ace/templates/cleaner/job.yaml
@@ -1,7 +1,7 @@
 apiVersion: batch/v1
 kind: Job
 metadata:
-  name: {{ include "ace.fullname" . }}-check
+  name: {{ include "ace.fullname" . }}-cleaner
   namespace: {{ .Release.Namespace }}
   annotations:
     "helm.sh/hook-weight": "0"
@@ -13,7 +13,7 @@ spec:
   template:
     spec:
       {{- include "appscode.imagePullSecrets" . | nindent 6 }}
-      serviceAccountName: {{ include "appscode.serviceAccountName" . }}-check
+      serviceAccountName: {{ include "appscode.serviceAccountName" . }}-cleaner
       automountServiceAccountToken: true
       securityContext:
         {{- toYaml .Values.podSecurityContext | nindent 8 }}
@@ -28,8 +28,6 @@ spec:
             - delete
             - jobs
             - --namespace={{ .Release.Namespace }}
-            - --field-selector
-            - status.successful=0
             - --selector
             - app.kubernetes.io/instance=ace
           resources:

diff --git a/charts/ace/templates/check/rbac.yaml → charts/ace/templates/cleaner/rbac.yaml b/charts/ace/templates/check/rbac.yaml → charts/ace/templates/cleaner/rbac.yaml
@@ -1,7 +1,7 @@
 apiVersion: rbac.authorization.k8s.io/v1
 kind: Role
 metadata:
-  name: {{ include "ace.fullname" . }}-check
+  name: {{ include "ace.fullname" . }}-cleaner
   namespace: {{ .Release.Namespace }}
   annotations:
     "helm.sh/hook-weight": "0"
@@ -20,7 +20,7 @@ rules:
 apiVersion: rbac.authorization.k8s.io/v1
 kind: RoleBinding
 metadata:
-  name: {{ include "ace.fullname" . }}-check
+  name: {{ include "ace.fullname" . }}-cleaner
   namespace: {{ .Release.Namespace }}
   annotations:
     "helm.sh/hook-weight": "0"
@@ -29,8 +29,8 @@ metadata:
 roleRef:
   apiGroup: rbac.authorization.k8s.io
   kind: Role
-  name: {{ include "ace.fullname" . }}-check
+  name: {{ include "ace.fullname" . }}-cleaner
 subjects:
 - kind: ServiceAccount
-  name: {{ include "appscode.serviceAccountName" . }}-check
+  name: {{ include "appscode.serviceAccountName" . }}-cleaner
   namespace: {{ .Release.Namespace }}
diff --git a/...s/ace/templates/check/serviceaccount.yaml → ...ace/templates/cleaner/serviceaccount.yaml b/...s/ace/templates/check/serviceaccount.yaml → ...ace/templates/cleaner/serviceaccount.yaml
@@ -2,7 +2,7 @@
 apiVersion: v1
 kind: ServiceAccount
 metadata:
-  name: {{ include "appscode.serviceAccountName" . }}-check
+  name: {{ include "appscode.serviceAccountName" . }}-cleaner
   namespace: {{ .Release.Namespace }}
   annotations:
     "helm.sh/hook-weight": "0"