Add react 18.1.0 to build matrix #567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ All good! |
luismiramirez
force-pushed
the
react-18-to-matrix
branch
3 times, most recently
from
b28127c to
2dbde25
Compare
Test against the latest stable version of React. To make it work, several packages had to be updated such as `@testing-library/react` and `typescript`. The testing library was the main one causing the test fail as React 18 changes how components are rendered, making version 11 incompatible. That's why the React 17 tests on the build matrix now explicitly define a previous testing library. Typescript was also updated as a dependency, version 4.4 now sets caught variables as `unknown` type if you have it configured as `strict`. That feature is disabled in this commit until we update how we handle errors in the library.
luismiramirez
force-pushed
the
react-18-to-matrix
branch
from
2dbde25 to
0c98b40
Compare
1 task
tombruijn
approved these changes
May 12, 2022
unflxw
approved these changes
May 13, 2022
luismiramirez
added a commit
that referenced
this pull request
May 26, 2022
We added React 18 compatibility in our tests and for that, we updated the integration package.json file. This update is also necessary for users that want to use React 18. This commit adds a changeset so we can publish those changes to NPM. Related PR: #567
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test against the latest stable version of React.
To make it work, several packages had to be updated such as
@testing-library/reactandtypescript.The testing library was the main one causing the tests fail as React 18
changes how components are rendered, making version 11 incompatible.
That's why the React 17 tests on the build matrix now explicitly define
a previous testing library.
Typescript was also updated as a dependency, version 4.4 now sets
caught variables as
unknowntype if you have it configured asstrict. That feature is disabled in this commit until we update how wehandle errors in the library.
Fixes: #564
[skip changeset]