Remove isomorphic-unfetch dependency from @appsignal/core
#622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An issue with `unfetch@5`, depended on by `[email protected]`, breaks bundling with tools such as `esbuild` and `webpack`: developit/unfetch#164
`isomorphic-unfetch` is only used in `@appsignal/core` to perform a push API validation request. This request is only ever performed by the CLI package. Move the push API validation request function to `@appsignal/cli` alongside with the dependency on `isomorphic-unfetch`, and remove `@appsignal/cli`'s dependency on `@appsignal/core`.
luismiramirez
approved these changes
Apr 23, 2024
tombruijn
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A more proper fix would be to use
node-fetchinstead ofunfetchorisomorphic-unfetch, but I just want to get a fix out for this problem that is affecting customers right now.Fixes #621.
Use [email protected] specifically
An issue with
unfetch@5, depended on by[email protected],breaks bundling with tools such as
esbuildandwebpack:developit/unfetch#164
Move isomorphic-unfetch dependency
isomorphic-unfetchis only used in@appsignal/coreto performa push API validation request. This request is only ever performed
by the CLI package.
Move the push API validation request function to
@appsignal/clialongside with the dependency on
isomorphic-unfetch, and remove@appsignal/cli's dependency on@appsignal/core.