Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix removed collider event not triggering #304

Merged
merged 1 commit into from
Nov 9, 2024
Merged

Conversation

Ughuuu
Copy link
Contributor

@Ughuuu Ughuuu commented Nov 9, 2024

@Ughuuu Ughuuu changed the title fix remvoed collider event fix removed collider event Nov 9, 2024
@Ughuuu Ughuuu changed the title fix removed collider event fix removed collider event not triggering Nov 9, 2024
@Changryy
Copy link

Changryy commented Nov 9, 2024

Does this also fix collision when using the disabled property on collision shapes?

@Ughuuu
Copy link
Contributor Author

Ughuuu commented Nov 9, 2024

Hm, not sure, I only tested the repro project you uploaded and it works with that.

@Ughuuu
Copy link
Contributor Author

Ughuuu commented Nov 9, 2024

Mergin and you can test with main build to see for yourself. Locally it seems good.

@Ughuuu Ughuuu merged commit 307f275 into main Nov 9, 2024
62 checks passed
@Ughuuu Ughuuu deleted the fix-removed-collider-event branch November 9, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Removing collision does not update Area2D
2 participants