Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement canary storage SLO #74

Merged
merged 1 commit into from
Jul 26, 2024
Merged

Implement canary storage SLO #74

merged 1 commit into from
Jul 26, 2024

Conversation

bastjan
Copy link
Contributor

@bastjan bastjan commented Jul 23, 2024 •
edited
Loading

Checklist

  • The PR has a meaningful title. It will be used to auto-generate the
    changelog.
    The PR has a meaningful description that sums up the change. It will be
    linked in the changelog.
  • PR contains a single logical change (to build a better changelog).
  • Update the documentation.
  • Categorize the PR by adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog.

@bastjan bastjan added the enhancement New feature or request label Jul 23, 2024
@bastjan bastjan requested a review from a team as a code owner July 23, 2024 13:01
@bastjan bastjan force-pushed the storage-canary branch 3 times, most recently from 1dd3cee to 1e09dce Compare July 23, 2024 14:07
@bastjan bastjan requested a review from simu July 23, 2024 15:58
simu
simu approved these changes Jul 25, 2024
View reviewed changes
Copy link
Member

@simu simu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 LGTM overall, some suggestions inline

component/main.jsonnet Outdated Show resolved Hide resolved
component/main.jsonnet Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 26, 2024 •
edited
Loading

🚀 This PR has been released as v1.10.0

Triggering workflows Release

🛠️ Auto tagging enabled with label bump:minor

@bastjan bastjan merged commit c93c044 into master Jul 26, 2024
10 checks passed
@bastjan bastjan deleted the storage-canary branch July 26, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DebakelOrakel DebakelOrakel DebakelOrakel approved these changes

@simu simu simu approved these changes

Assignees
No one assigned
Labels
bump:minor enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bastjan @simu @DebakelOrakel