fix: allow using a different namespace for the auth

[taktakpeops]

Use different namespace for fetching the auth secret for Git in case it's specified

Use case:

revision ->

apiVersion: terraform.appvia.io/v1alpha1
kind: Revision
metadata:
  name: my-revision
  namespace: my-ns
spec:
  # more config
  configuration:
    auth:
      name: auth
      namespace: other-ns

In this case the controller fails because it can't find the auth secret in my-ns.

My PR checks if spec.configuration.auth.namespace is set and use this namespace in case it's present to get the secret

[gambol99]

Very sorry for the length of time passed on this review @taktakpeops!! … been away for an extended holiday

The only concern adding the feature; it technically allows for a user to circumvent permissions and gain access to secrets in other namespaces i.e. just write a module that prints the x variables, reference a secret in another namespace and you can grab the log outputs …

What was the use case you were looking to fix?

cc @KashifSaadat

[gambol99]

Very sorry for the length of time passed on this review @taktakpeops!! … been away for an extended holiday

The only concern adding the feature; it technically allows for a user to circumvent permissions and gain access to secrets in other namespaces i.e. just write a module that prints the x variables, reference a secret in another namespace and you can grab the log outputs …

What was the use case you were looking to fix?

cc @KashifSaadat

Back from holiday blunder! :-) … i was thinking about variables not auth, this should technically be fine .. I’m wondering if using https://terranetes.appvia.io/terranetes-controller/admin/defaults/#secrets would fix your issue without changes - assuming the use case you want is a shared secret for auth in the Revisions