Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Also set resource k8s limits/requests on the apply job #1553

Merged
merged 2 commits into from
Nov 13, 2024

Conversation

ronaldvb-k
Copy link
Contributor

The plan job has k8s resources as specified in our Helm values, but the apply job doesn't use them.
This PR should fix this.

terranetes-controller:
  controller:
    extraArgs:
      executor-cpu-limit: 1
      executor-cpu-request: 5m
      executor-memory-limit: 2Gi
      executor-memory-request: 32Mi

Plan:

$ k -n terraform-system get po resource.acr-plan-8tndq-vkgtk -ojsonpath='{.spec.containers[0].resources}' | yq -P
limits:
  cpu: "1"
  memory: 2Gi
requests:
  cpu: 5m
  memory: 32Mi

Apply:

$ k -n terraform-system get po resource.acr-apply-hgtmw-hxslf -ojsonpath='{.spec.containers[0].resources}'|yq -P
requests:
  cpu: "0"
  memory: "0"

gambol99 and others added 2 commits November 10, 2024 17:30
The current helm chart has a typo in the 'controller.jobsLabels', this should have been 'controller.jobLabels', which is what the actual template references
@gambol99 gambol99 changed the base branch from master to develop November 11, 2024 17:19
Copy link
Member

@gambol99 gambol99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM … thank you @ronaldvb-k

@gambol99 gambol99 merged commit d039b61 into appvia:develop Nov 13, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants