Fix queuetime expression

appzen-oss · Aug 27, 2020 · 3c5868c · 3c5868c
1 parent 0dfb799
commit 3c5868c
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/main.tf b/main.tf
@@ -368,15 +368,15 @@ resource "aws_cloudwatch_metric_alarm" "queue_time" {
   # Requires ECS ContainerInsights to be enabled: aws ecs update-cluster-settings --cluster <cluster name> --settings name=containerInsights,value=enabled
   # ECS cluster name and service name
 
-  alarm_name          = "${module.label.id}-sqs-big-up"
+  alarm_name          = "${module.label.id}-sqs-queuetime-up"
   alarm_description   = "Alarm monitors ${var.queue_name} QueueTime = ((Queue Size * Worker Timing) / (number of current tasks * Number Of workers per task))"
   comparison_operator = "GreaterThanThreshold"
   evaluation_periods  = "1"
   threshold           = "${var.queue_time_threshold}"
   alarm_actions       = ["${aws_appautoscaling_policy.scale_queuetime_up.arn}"]
   metric_query {
     id          = "queuetime"
-    expression  = "((visible+notvisible) * ${var.queue_worker_timing}) / (taskcount * ${var.queue_task_worker_count}))"
+    expression  = "((visible+notvisible) * ${var.queue_worker_timing}) / (taskcount * ${var.queue_task_worker_count})"
     label       = "WaitTime"
     return_data = "true"
   }

diff --git a/variables.tf b/variables.tf
@@ -92,7 +92,7 @@ variable "queue_worker_timing" {
 
 variable "queue_task_worker_count" {
   description = "number of Workers per Task in calculation queue_time_threshold"
-  default     = "1"
+  default     = "4"
 }
 
 variable "scale_down_cooldown" {