Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor updates and fixes #141

Merged
merged 5 commits into from
May 18, 2020
Merged

Minor updates and fixes #141

merged 5 commits into from
May 18, 2020

Conversation

proditis
Copy link
Contributor

@proditis proditis commented May 5, 2020

Add link to the official book website as well as an alternative download link. 

I think we should only keep the official book website and not provide the link to pdf copies since the book isn't free...

issue #135
Although DVWA is not the exact match for either of these sections, i believe it is a better match for the self-hosted section rather than the Tutorials.
README.md Outdated
@@ -46,7 +46,7 @@ It takes time to build up collection of tools used in CTF and remember them all.

*Tools used for creating CTF challenges*

- [Kali Linux CTF Blueprints](https://doc.lagout.org/security/Packt.Kali.Linux.CTF.Blueprints.Jul.2014.ISBN.1783985984.pdf) - Online book on building, testing, and customizing your own Capture the Flag challenges.
- [Kali Linux CTF Blueprints](https://www.packtpub.com/eu/networking-and-servers/kali-linux-ctf-blueprints) / [download link](https://mega.nz/#!ijQgQKTY!EvhUfLAm7hvV4eLGEVnRRp-lzn7f7JpmMGEZzf-_Kn0) - Online book on building, testing, and customizing your own Capture the Flag challenges.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a pirated version. Unsure if we should add this to the repo. Thoughts @apsdehal ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @DhavalKapil I added the pdf download simply because it used to have it before.
I'd rather we do not include the download link.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, can you remove it from the PR?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed it and also resolved the conflict

@DhavalKapil DhavalKapil merged commit eb504b2 into apsdehal:master May 18, 2020
@DhavalKapil
Copy link
Collaborator

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants