Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the workflow to release protos. #15801

Merged
merged 1 commit into from
Jan 24, 2025
Merged

Conversation

larry-aptos
Copy link
Contributor

@larry-aptos larry-aptos commented Jan 23, 2025

Description

Fix the polling script.

How Has This Been Tested?

Tested and looks good.

image

Key Areas to Review

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Move Compiler
  • Other (specify)

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

Copy link

trunk-io bot commented Jan 23, 2025

⏱️ 3h 51m total CI duration on this PR
Slowest 15 Jobs Cumulative Duration Recent Runs
update-sdk 1h 50m 🟥🟩🟥🟥🟥
check-dynamic-deps 30m 🟩🟩🟩🟩🟩 (+5 more)
forge-compat-test / forge 22m 🟥🟩
check-protos 14m 🟩🟩🟩🟩🟩
forge-e2e-test / forge 13m 🟩
rust-cargo-deny 12m 🟩🟩🟩 (+4 more)
rust-doc-tests 5m 🟩
test-target-determinator 5m 🟩
execution-performance / test-target-determinator 5m 🟩
semgrep/ci 4m 🟩🟩🟩🟩🟩 (+5 more)
general-lints 4m 🟩🟩🟩🟩 (+4 more)
file_change_determinator 3m 🟩🟩🟩🟩🟩 (+5 more)
fetch-last-released-docker-image-tag 2m 🟩
permission-check 25s 🟩🟩🟩🟩🟩 (+5 more)
permission-check 25s 🟩🟩🟩🟩🟩 (+5 more)

🚨 1 job on the last run was significantly faster/slower than expected

Job Duration vs 7d avg Delta
execution-performance / single-node-performance 10s 17m -99%

settingsfeedbackdocs ⋅ learn more about trunk.io

@larry-aptos larry-aptos marked this pull request as ready for review January 23, 2025 21:38
Copy link
Contributor Author

larry-aptos commented Jan 23, 2025

@larry-aptos larry-aptos force-pushed the 01-23-test_the_new_workflow branch from 9927bb6 to 334d94f Compare January 23, 2025 21:42
@larry-aptos larry-aptos requested a review from a team as a code owner January 23, 2025 21:42
@larry-aptos larry-aptos force-pushed the 01-23-test_the_new_workflow branch 4 times, most recently from 795bf95 to 7a4a5a7 Compare January 23, 2025 21:54
Base automatically changed from 01-22-add_workflow_that_monitors_the_downstream_test_result to main January 23, 2025 22:10
@larry-aptos larry-aptos force-pushed the 01-23-test_the_new_workflow branch from 7a4a5a7 to 9397a22 Compare January 23, 2025 23:36
@larry-aptos larry-aptos force-pushed the 01-23-test_the_new_workflow branch from 9397a22 to eb0caee Compare January 23, 2025 23:37
@larry-aptos larry-aptos requested a review from a team January 23, 2025 23:40
@larry-aptos larry-aptos changed the title Test the new workflow. Fixed the workflow to release protos. Jan 23, 2025
@larry-aptos larry-aptos enabled auto-merge (squash) January 23, 2025 23:41

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

✅ Forge suite realistic_env_max_load success on eb0caee0ad1eb68ccb377d40f3e6178a7544178d

two traffics test: inner traffic : committed: 14718.21 txn/s, latency: 2694.39 ms, (p50: 2400 ms, p70: 2700, p90: 3300 ms, p99: 4800 ms), latency samples: 5596180
two traffics test : committed: 99.96 txn/s, latency: 1892.67 ms, (p50: 1400 ms, p70: 1600, p90: 3300 ms, p99: 6300 ms), latency samples: 1720
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 1.246, avg: 1.049", "ConsensusProposalToOrdered: max: 0.299, avg: 0.292", "ConsensusOrderedToCommit: max: 0.412, avg: 0.400", "ConsensusProposalToCommit: max: 0.704, avg: 0.693"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.96s no progress at version 29672 (avg 0.20s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.67s no progress at version 2827010 (avg 0.67s) [limit 16].
Test Ok

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

✅ Forge suite compat success on 9e7cf4a27cc20504cee5ffefc35bd8e7792dde36 ==> eb0caee0ad1eb68ccb377d40f3e6178a7544178d

Compatibility test results for 9e7cf4a27cc20504cee5ffefc35bd8e7792dde36 ==> eb0caee0ad1eb68ccb377d40f3e6178a7544178d (PR)
1. Check liveness of validators at old version: 9e7cf4a27cc20504cee5ffefc35bd8e7792dde36
compatibility::simple-validator-upgrade::liveness-check : committed: 12684.99 txn/s, latency: 2508.16 ms, (p50: 2600 ms, p70: 2700, p90: 3000 ms, p99: 3300 ms), latency samples: 417660
2. Upgrading first Validator to new version: eb0caee0ad1eb68ccb377d40f3e6178a7544178d
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 4307.83 txn/s, latency: 7260.85 ms, (p50: 8000 ms, p70: 8600, p90: 8900 ms, p99: 9100 ms), latency samples: 92120
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 4338.43 txn/s, latency: 7836.90 ms, (p50: 8700 ms, p70: 9000, p90: 9300 ms, p99: 9400 ms), latency samples: 152520
3. Upgrading rest of first batch to new version: eb0caee0ad1eb68ccb377d40f3e6178a7544178d
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 4194.23 txn/s, latency: 7442.33 ms, (p50: 8200 ms, p70: 8800, p90: 9100 ms, p99: 9400 ms), latency samples: 91080
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 4264.23 txn/s, latency: 7957.47 ms, (p50: 9000 ms, p70: 9000, p90: 9300 ms, p99: 9400 ms), latency samples: 149120
4. upgrading second batch to new version: eb0caee0ad1eb68ccb377d40f3e6178a7544178d
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 8004.77 txn/s, latency: 3871.26 ms, (p50: 4500 ms, p70: 4700, p90: 5000 ms, p99: 5100 ms), latency samples: 148800
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 7897.88 txn/s, latency: 4325.87 ms, (p50: 4700 ms, p70: 4800, p90: 5100 ms, p99: 5300 ms), latency samples: 264160
5. check swarm health
Compatibility test for 9e7cf4a27cc20504cee5ffefc35bd8e7792dde36 ==> eb0caee0ad1eb68ccb377d40f3e6178a7544178d passed
Test Ok

@larry-aptos larry-aptos merged commit e6d8b40 into main Jan 24, 2025
84 of 88 checks passed
@larry-aptos larry-aptos deleted the 01-23-test_the_new_workflow branch January 24, 2025 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants