Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix simulate serialization #15822

Merged
merged 2 commits into from
Feb 3, 2025
Merged

Fix simulate serialization #15822

merged 2 commits into from
Feb 3, 2025

Conversation

runtian-zhou
Copy link
Contributor

@runtian-zhou runtian-zhou commented Jan 27, 2025

Description

Fix serialization for release-builder simulation.

How Has This Been Tested?

TBD

Key Areas to Review

N/A

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Move Compiler
  • Other (specify) Release process

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • [] I tested both happy and unhappy path of the functionality
  • [] I have made corresponding changes to the documentation

Copy link

trunk-io bot commented Jan 27, 2025

⏱️ 59m total CI duration on this PR
Slowest 15 Jobs Cumulative Duration Recent Runs
test-target-determinator 10m 🟩🟩
execution-performance / test-target-determinator 9m 🟩🟩
check-dynamic-deps 9m 🟩🟩🟩🟩🟩
rust-cargo-deny 9m 🟩🟩🟩🟩🟩
rust-doc-tests 7m 🟩
rust-doc-tests 5m 🟩
fetch-last-released-docker-image-tag 3m 🟩🟩
semgrep/ci 2m 🟩🟩🟩🟩🟩
general-lints 2m 🟩🟩🟩🟩🟩
file_change_determinator 1m 🟩🟩🟩🟩🟩
file_change_determinator 32s 🟩🟩
execution-performance / single-node-performance 19s 🟩🟩
permission-check 15s 🟩🟩🟩🟩🟩
permission-check 11s 🟩🟩🟩🟩🟩
determine-docker-build-metadata 6s 🟩🟩

🚨 1 job on the last run was significantly faster/slower than expected

Job Duration vs 7d avg Delta
execution-performance / single-node-performance 9s 18m -99%

settingsfeedbackdocs ⋅ learn more about trunk.io

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@runtian-zhou runtian-zhou marked this pull request as ready for review January 27, 2025 19:10
@runtian-zhou runtian-zhou force-pushed the 01-27-fix_simulate_serialization branch from 6c4e7ab to d5a6e8c Compare January 27, 2025 19:13
@runtian-zhou runtian-zhou force-pushed the 01-27-fix_simulate_serialization branch from d5a6e8c to 86af509 Compare January 27, 2025 19:18
@vgao1996 vgao1996 enabled auto-merge (squash) January 27, 2025 21:41

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

github-actions bot commented Feb 3, 2025

✅ Forge suite compat success on 60f7ca8827f5d64a148c3b163dc4126b0879279b ==> 5f62614e8fe1f2984aeaedf54cc3a5341d7df08f

Compatibility test results for 60f7ca8827f5d64a148c3b163dc4126b0879279b ==> 5f62614e8fe1f2984aeaedf54cc3a5341d7df08f (PR)
1. Check liveness of validators at old version: 60f7ca8827f5d64a148c3b163dc4126b0879279b
compatibility::simple-validator-upgrade::liveness-check : committed: 5861.44 txn/s, submitted: 5861.61 txn/s, expired: 0.17 txn/s, latency: 2733.71 ms, (p50: 2600 ms, p70: 2900, p90: 3700 ms, p99: 5000 ms), latency samples: 381669
2. Upgrading first Validator to new version: 5f62614e8fe1f2984aeaedf54cc3a5341d7df08f
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 3399.57 txn/s, latency: 8748.48 ms, (p50: 9400 ms, p70: 10500, p90: 11200 ms, p99: 11400 ms), latency samples: 75180
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 3376.12 txn/s, latency: 10203.43 ms, (p50: 11200 ms, p70: 11500, p90: 11500 ms, p99: 11800 ms), latency samples: 128100
3. Upgrading rest of first batch to new version: 5f62614e8fe1f2984aeaedf54cc3a5341d7df08f
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 3320.65 txn/s, latency: 8889.32 ms, (p50: 9600 ms, p70: 10800, p90: 11600 ms, p99: 11700 ms), latency samples: 73060
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 2095.41 txn/s, submitted: 2095.59 txn/s, expired: 0.18 txn/s, latency: 10296.21 ms, (p50: 11200 ms, p70: 11500, p90: 11800 ms, p99: 11900 ms), latency samples: 127669
4. upgrading second batch to new version: 5f62614e8fe1f2984aeaedf54cc3a5341d7df08f
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 5536.12 txn/s, latency: 5433.90 ms, (p50: 6100 ms, p70: 6300, p90: 7300 ms, p99: 7400 ms), latency samples: 108060
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 5547.49 txn/s, latency: 6131.21 ms, (p50: 6400 ms, p70: 7000, p90: 7300 ms, p99: 7600 ms), latency samples: 193580
5. check swarm health
Compatibility test for 60f7ca8827f5d64a148c3b163dc4126b0879279b ==> 5f62614e8fe1f2984aeaedf54cc3a5341d7df08f passed
Test Ok

Copy link
Contributor

github-actions bot commented Feb 3, 2025

✅ Forge suite realistic_env_max_load success on 5f62614e8fe1f2984aeaedf54cc3a5341d7df08f

two traffics test: inner traffic : committed: 12729.65 txn/s, latency: 3118.56 ms, (p50: 2700 ms, p70: 3600, p90: 4500 ms, p99: 5400 ms), latency samples: 4840120
two traffics test : committed: 99.96 txn/s, latency: 2927.99 ms, (p50: 2500 ms, p70: 3400, p90: 4800 ms, p99: 5300 ms), latency samples: 1760
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 0.556, avg: 0.279", "ConsensusProposalToOrdered: max: 0.316, avg: 0.304", "ConsensusOrderedToCommit: max: 0.640, avg: 0.550", "ConsensusProposalToCommit: max: 0.948, avg: 0.854"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.63s no progress at version 2128949 (avg 0.20s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.65s no progress at version 2117026 (avg 0.65s) [limit 16].
Test Ok

Copy link
Contributor

github-actions bot commented Feb 3, 2025

✅ Forge suite framework_upgrade success on 60f7ca8827f5d64a148c3b163dc4126b0879279b ==> 5f62614e8fe1f2984aeaedf54cc3a5341d7df08f

Compatibility test results for 60f7ca8827f5d64a148c3b163dc4126b0879279b ==> 5f62614e8fe1f2984aeaedf54cc3a5341d7df08f (PR)
Upgrade the nodes to version: 5f62614e8fe1f2984aeaedf54cc3a5341d7df08f
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1585.96 txn/s, submitted: 1591.36 txn/s, failed submission: 5.40 txn/s, expired: 5.40 txn/s, latency: 1881.16 ms, (p50: 1800 ms, p70: 2100, p90: 2700 ms, p99: 4000 ms), latency samples: 140880
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1699.99 txn/s, submitted: 1705.31 txn/s, failed submission: 5.32 txn/s, expired: 5.32 txn/s, latency: 1703.95 ms, (p50: 1600 ms, p70: 2000, p90: 2500 ms, p99: 3300 ms), latency samples: 153501
5. check swarm health
Compatibility test for 60f7ca8827f5d64a148c3b163dc4126b0879279b ==> 5f62614e8fe1f2984aeaedf54cc3a5341d7df08f passed
Upgrade the remaining nodes to version: 5f62614e8fe1f2984aeaedf54cc3a5341d7df08f
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1750.43 txn/s, submitted: 1755.55 txn/s, failed submission: 5.11 txn/s, expired: 5.11 txn/s, latency: 1656.95 ms, (p50: 1500 ms, p70: 1900, p90: 2400 ms, p99: 3700 ms), latency samples: 157504
Test Ok

@vgao1996 vgao1996 merged commit ab9da6b into main Feb 3, 2025
46 checks passed
@vgao1996 vgao1996 deleted the 01-27-fix_simulate_serialization branch February 3, 2025 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants