Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump gas version on main #15826

Merged
merged 1 commit into from
Jan 31, 2025
Merged

Bump gas version on main #15826

merged 1 commit into from
Jan 31, 2025

Conversation

igor-aptos
Copy link
Contributor

and update release.yaml template closer to what is used in the release, and add more details on release folder issues.

Description

How Has This Been Tested?

Key Areas to Review

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Move Compiler
  • Other (specify)

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

Copy link

trunk-io bot commented Jan 28, 2025

⏱️ 2h 3m total CI duration on this PR
Slowest 15 Jobs Cumulative Duration Recent Runs
execution-performance / single-node-performance 52m 🟥🟥🟩
execution-performance / test-target-determinator 16m 🟩🟩🟩
test-target-determinator 11m 🟩🟩
check-dynamic-deps 9m 🟩🟩🟩🟩🟩
rust-cargo-deny 9m 🟩🟩🟩🟩
rust-doc-tests 6m 🟩
rust-doc-tests 6m 🟩
fetch-last-released-docker-image-tag 5m 🟩🟩
general-lints 4m 🟩🟩🟩🟩🟩
semgrep/ci 2m 🟩🟩🟩🟩🟩
rust-doc-tests 1m
file_change_determinator 54s 🟩🟩🟩🟩🟩
file_change_determinator 31s 🟩🟩🟩
permission-check 11s 🟩🟩🟩🟩🟩
permission-check 11s 🟩🟩🟩🟩🟩

🚨 2 jobs on the last run were significantly faster/slower than expected

Job Duration vs 7d avg Delta
general-lints 2m 28s +221%
check-dynamic-deps 1m 2m -43%

settingsfeedbackdocs ⋅ learn more about trunk.io

Copy link
Contributor

@perryjrandall perryjrandall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lint failed

@igor-aptos igor-aptos force-pushed the igor/bump_main_gas_version branch from a3d8f47 to 3421453 Compare January 28, 2025 23:58
@igor-aptos igor-aptos enabled auto-merge (squash) January 29, 2025 00:45

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@igor-aptos igor-aptos force-pushed the igor/bump_main_gas_version branch from 3421453 to c89a2f6 Compare January 31, 2025 18:40
and update release.yaml template closer to what is used in the release, and add more details on release folder issues.
@igor-aptos igor-aptos force-pushed the igor/bump_main_gas_version branch from c89a2f6 to 453339a Compare January 31, 2025 18:41

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

✅ Forge suite realistic_env_max_load success on 453339aa67fe85bc3b9905e8d262b10177de72a0

two traffics test: inner traffic : committed: 14521.10 txn/s, latency: 2737.68 ms, (p50: 2400 ms, p70: 2500, p90: 3600 ms, p99: 7200 ms), latency samples: 5521300
two traffics test : committed: 99.98 txn/s, latency: 3028.78 ms, (p50: 1500 ms, p70: 3600, p90: 6900 ms, p99: 9300 ms), latency samples: 1840
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 1.333, avg: 1.009", "ConsensusProposalToOrdered: max: 0.300, avg: 0.295", "ConsensusOrderedToCommit: max: 0.452, avg: 0.423", "ConsensusProposalToCommit: max: 0.746, avg: 0.718"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.82s no progress at version 27690 (avg 0.20s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.73s no progress at version 2470221 (avg 0.73s) [limit 16].
Test Ok

Copy link
Contributor

✅ Forge suite compat success on 60f7ca8827f5d64a148c3b163dc4126b0879279b ==> 453339aa67fe85bc3b9905e8d262b10177de72a0

Compatibility test results for 60f7ca8827f5d64a148c3b163dc4126b0879279b ==> 453339aa67fe85bc3b9905e8d262b10177de72a0 (PR)
1. Check liveness of validators at old version: 60f7ca8827f5d64a148c3b163dc4126b0879279b
compatibility::simple-validator-upgrade::liveness-check : committed: 11950.47 txn/s, latency: 2647.19 ms, (p50: 2500 ms, p70: 3000, p90: 3600 ms, p99: 4500 ms), latency samples: 399840
2. Upgrading first Validator to new version: 453339aa67fe85bc3b9905e8d262b10177de72a0
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 4283.00 txn/s, latency: 7238.02 ms, (p50: 8000 ms, p70: 8500, p90: 8900 ms, p99: 9000 ms), latency samples: 90900
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 4298.55 txn/s, latency: 7896.05 ms, (p50: 8900 ms, p70: 8900, p90: 9300 ms, p99: 9400 ms), latency samples: 151380
3. Upgrading rest of first batch to new version: 453339aa67fe85bc3b9905e8d262b10177de72a0
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 1105.75 txn/s, submitted: 1105.90 txn/s, expired: 0.15 txn/s, latency: 8141.91 ms, (p50: 8800 ms, p70: 9600, p90: 10300 ms, p99: 10500 ms), latency samples: 83809
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 3965.97 txn/s, latency: 8623.27 ms, (p50: 9500 ms, p70: 9900, p90: 10200 ms, p99: 10300 ms), latency samples: 140280
4. upgrading second batch to new version: 453339aa67fe85bc3b9905e8d262b10177de72a0
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 7932.08 txn/s, latency: 3832.84 ms, (p50: 4300 ms, p70: 4800, p90: 5000 ms, p99: 5100 ms), latency samples: 148520
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 7998.38 txn/s, latency: 4288.79 ms, (p50: 4600 ms, p70: 4900, p90: 5000 ms, p99: 5300 ms), latency samples: 266580
5. check swarm health
Compatibility test for 60f7ca8827f5d64a148c3b163dc4126b0879279b ==> 453339aa67fe85bc3b9905e8d262b10177de72a0 passed
Test Ok

Copy link
Contributor

✅ Forge suite framework_upgrade success on 60f7ca8827f5d64a148c3b163dc4126b0879279b ==> 453339aa67fe85bc3b9905e8d262b10177de72a0

Compatibility test results for 60f7ca8827f5d64a148c3b163dc4126b0879279b ==> 453339aa67fe85bc3b9905e8d262b10177de72a0 (PR)
Upgrade the nodes to version: 453339aa67fe85bc3b9905e8d262b10177de72a0
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1787.56 txn/s, submitted: 1792.20 txn/s, failed submission: 4.64 txn/s, expired: 4.64 txn/s, latency: 1615.37 ms, (p50: 1500 ms, p70: 1800, p90: 2400 ms, p99: 3300 ms), latency samples: 161800
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1634.19 txn/s, submitted: 1638.02 txn/s, failed submission: 3.83 txn/s, expired: 3.83 txn/s, latency: 1767.90 ms, (p50: 1800 ms, p70: 1900, p90: 2600 ms, p99: 3900 ms), latency samples: 145060
5. check swarm health
Compatibility test for 60f7ca8827f5d64a148c3b163dc4126b0879279b ==> 453339aa67fe85bc3b9905e8d262b10177de72a0 passed
Upgrade the remaining nodes to version: 453339aa67fe85bc3b9905e8d262b10177de72a0
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1985.83 txn/s, submitted: 1991.32 txn/s, failed submission: 5.49 txn/s, expired: 5.49 txn/s, latency: 1433.98 ms, (p50: 1300 ms, p70: 1500, p90: 2100 ms, p99: 2700 ms), latency samples: 180781
Test Ok

@igor-aptos igor-aptos merged commit d9655ac into main Jan 31, 2025
46 checks passed
@igor-aptos igor-aptos deleted the igor/bump_main_gas_version branch January 31, 2025 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants