[Consensus Observer] Small improvements to message metrics. #15864

JoshLind · 2025-02-01T16:40:08Z

Description

This small PR makes tiny improvements to the message metrics for consensus observer. Specifically, we: (i) add a new counter to track invalid messages; and (ii) refactor some of the logic into shared methods.

Testing Plan

Existing test infrastructure.

trunk-io · 2025-02-01T16:40:12Z

⏱️ 27m total CI duration on this PR

Job	Cumulative Duration	Recent Runs
rust-doc-tests	6m	🟩
test-target-determinator	5m	🟩
execution-performance / test-target-determinator	5m	🟩
check-dynamic-deps	4m	🟩 🟩
rust-cargo-deny	4m	🟩 🟩
fetch-last-released-docker-image-tag	2m	🟩
general-lints	56s	🟩 🟩
semgrep/ci	45s	🟩 🟩
file_change_determinator	20s	🟩 🟩
file_change_determinator	10s	🟩
execution-performance / single-node-performance	9s	🟩
permission-check	6s	🟩 🟩
permission-check	5s	🟩 🟩
permission-check	2s	🟩
determine-docker-build-metadata	2s	🟩

🚨 1 job on the last run was significantly faster/slower than expected

Job	Duration	vs 7d avg	Delta
execution-performance / single-node-performance	9s	21m

_{settings ⋅ feedback ⋅ docs ⋅ learn more about trunk.io}

github-actions · 2025-02-03T02:11:33Z

❌ Forge suite `realistic_env_max_load` failure on `045e772b02bc9da82975ccb32a362075357e6879`

two traffics test: inner traffic : committed: 13080.95 txn/s, latency: 3039.22 ms, (p50: 2700 ms, p70: 3300, p90: 4500 ms, p99: 6000 ms), latency samples: 4973780
two traffics test : committed: 99.99 txn/s, latency: 3194.73 ms, (p50: 2700 ms, p70: 3500, p90: 5100 ms, p99: 8700 ms), latency samples: 1840
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 0.663, avg: 0.268", "ConsensusProposalToOrdered: max: 0.315, avg: 0.299", "ConsensusOrderedToCommit: max: 1.075, avg: 0.613", "ConsensusProposalToCommit: max: 1.390, avg: 0.912"]
Test Failed: check for success

Caused by:
    "ConsensusOrderedToCommit" metric violated threshold of 1.0, max_breach_pct: 5, breach_pct: 7 

Stack backtrace:
   0: anyhow::error::<impl anyhow::Error>::msg
             at /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/anyhow-1.0.89/src/error.rs:85:36
   1: aptos_forge::success_criteria::MetricsThreshold::ensure_metrics_threshold
   2: aptos_forge::success_criteria::LatencyBreakdownThreshold::ensure_threshold
             at ./testsuite/forge/src/success_criteria.rs:156:13
   3: aptos_forge::success_criteria::SuccessCriteriaChecker::check_for_success::{{closure}}
             at ./testsuite/forge/src/success_criteria.rs:314:13
   4: aptos_forge::interface::network::NetworkContext::check_for_success::{{closure}}
             at ./testsuite/forge/src/interface/network.rs:112:10
   5: <dyn aptos_testcases::NetworkLoadTest as aptos_forge::interface::network::NetworkTest>::run::{{closure}}
             at ./testsuite/testcases/src/lib.rs:333:14
   6: <core::pin::Pin<P> as core::future::future::Future>::poll
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/core/src/future/future.rs:123:9
   7: <aptos_testcases::two_traffics_test::TwoTrafficsTest as aptos_forge::interface::network::NetworkTest>::run::{{closure}}
             at ./testsuite/testcases/src/two_traffics_test.rs:77:47
   8: <core::pin::Pin<P> as core::future::future::Future>::poll
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/core/src/future/future.rs:123:9
   9: <aptos_testcases::CompositeNetworkTest as aptos_forge::interface::network::NetworkTest>::run::{{closure}}
             at ./testsuite/testcases/src/lib.rs:639:37
  10: <core::pin::Pin<P> as core::future::future::Future>::poll
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/core/src/future/future.rs:123:9
  11: tokio::runtime::park::CachedParkThread::block_on::{{closure}}
             at /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.40.0/src/runtime/park.rs:281:63
  12: tokio::runtime::coop::with_budget
             at /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.40.0/src/runtime/coop.rs:107:5
  13: tokio::runtime::coop::budget
             at /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.40.0/src/runtime/coop.rs:73:5
  14: tokio::runtime::park::CachedParkThread::block_on
             at /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.40.0/src/runtime/park.rs:281:31
  15: tokio::runtime::context::blocking::BlockingRegionGuard::block_on
             at /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.40.0/src/runtime/context/blocking.rs:66:9
  16: tokio::runtime::handle::Handle::block_on_inner::{{closure}}
             at /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.40.0/src/runtime/handle.rs:324:22
  17: tokio::runtime::context::runtime::enter_runtime
             at /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.40.0/src/runtime/context/runtime.rs:65:16
  18: tokio::runtime::handle::Handle::block_on_inner
             at /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.40.0/src/runtime/handle.rs:323:9
  19: tokio::runtime::handle::Handle::block_on
             at /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.40.0/src/runtime/handle.rs:302:18
  20: aptos_forge::runner::Forge<F>::run
             at ./testsuite/forge/src/runner.rs:332:50
  21: forge::run_forge_with_changelog
             at ./testsuite/forge-cli/src/main.rs:428:24
  22: forge::main
             at ./testsuite/forge-cli/src/main.rs:331:21
  23: core::ops::function::FnOnce::call_once
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/core/src/ops/function.rs:250:5
  24: std::sys_common::backtrace::__rust_begin_short_backtrace
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/sys_common/backtrace.rs:155:18
  25: std::rt::lang_start::{{closure}}
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/rt.rs:166:18
  26: core::ops::function::impls::<impl core::ops::function::FnOnce<A> for &F>::call_once
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/core/src/ops/function.rs:284:13
  27: std::panicking::try::do_call
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/panicking.rs:552:40
  28: std::panicking::try
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/panicking.rs:516:19
  29: std::panic::catch_unwind
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/panic.rs:146:14
  30: std::rt::lang_start_internal::{{closure}}
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/rt.rs:148:48
  31: std::panicking::try::do_call
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/panicking.rs:552:40
  32: std::panicking::try
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/panicking.rs:516:19
  33: std::panic::catch_unwind
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/panic.rs:146:14
  34: std::rt::lang_start_internal
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/rt.rs:148:20
  35: main
  36: __libc_start_main
  37: _start
Trailing Log Lines:
  32: std::panicking::try
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/panicking.rs:516:19
  33: std::panic::catch_unwind
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/panic.rs:146:14
  34: std::rt::lang_start_internal
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/rt.rs:148:20
  35: main
  36: __libc_start_main
  37: _start

=== BEGIN JUNIT ===
<?xml version="1.0" encoding="UTF-8"?>
<testsuites name="forge" tests="1" failures="1" errors="0" uuid="bcd3cc69-6b43-48d1-96a5-5422c72df0a4">
    <testsuite name="local" tests="1" disabled="0" errors="0" failures="1">
        <testcase name="CompositeNetworkTest(CpuChaosWrapper(network:multi-region-network-emulation(two traffics test))) with ">
            <failure message="check for success

Caused by:
    &quot;ConsensusOrderedToCommit&quot; metric violated threshold of 1.0, max_breach_pct: 5, breach_pct: 7 

Stack backtrace:
   0: anyhow::error::&lt;impl anyhow::Error&gt;::msg
             at /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/anyhow-1.0.89/src/error.rs:85:36
   1: aptos_forge::success_criteria::MetricsThreshold::ensure_metrics_threshold
   2: aptos_forge::success_criteria::LatencyBreakdownThreshold::ensure_threshold
             at ./testsuite/forge/src/success_criteria.rs:156:13
   3: aptos_forge::success_criteria::SuccessCriteriaChecker::check_for_success::{{closure}}
             at ./testsuite/forge/src/success_criteria.rs:314:13
   4: aptos_forge::interface::network::NetworkContext::check_for_success::{{closure}}
             at ./testsuite/forge/src/interface/network.rs:112:10
   5: &lt;dyn aptos_testcases::NetworkLoadTest as aptos_forge::interface::network::NetworkTest&gt;::run::{{closure}}
             at ./testsuite/testcases/src/lib.rs:333:14
   6: &lt;core::pin::Pin&lt;P&gt; as core::future::future::Future&gt;::poll
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/core/src/future/future.rs:123:9
   7: &lt;aptos_testcases::two_traffics_test::TwoTrafficsTest as aptos_forge::interface::network::NetworkTest&gt;::run::{{closure}}
             at ./testsuite/testcases/src/two_traffics_test.rs:77:47
   8: &lt;core::pin::Pin&lt;P&gt; as core::future::future::Future&gt;::poll
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/core/src/future/future.rs:123:9
   9: &lt;aptos_testcases::CompositeNetworkTest as aptos_forge::interface::network::NetworkTest&gt;::run::{{closure}}
             at ./testsuite/testcases/src/lib.rs:639:37
  10: &lt;core::pin::Pin&lt;P&gt; as core::future::future::Future&gt;::poll
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/core/src/future/future.rs:123:9
  11: tokio::runtime::park::CachedParkThread::block_on::{{closure}}
             at /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.40.0/src/runtime/park.rs:281:63
  12: tokio::runtime::coop::with_budget
             at /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.40.0/src/runtime/coop.rs:107:5
  13: tokio::runtime::coop::budget
             at /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.40.0/src/runtime/coop.rs:73:5
  14: tokio::runtime::park::CachedParkThread::block_on
             at /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.40.0/src/runtime/park.rs:281:31
  15: tokio::runtime::context::blocking::BlockingRegionGuard::block_on
             at /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.40.0/src/runtime/context/blocking.rs:66:9
  16: tokio::runtime::handle::Handle::block_on_inner::{{closure}}
             at /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.40.0/src/runtime/handle.rs:324:22
  17: tokio::runtime::context::runtime::enter_runtime
             at /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.40.0/src/runtime/context/runtime.rs:65:16
  18: tokio::runtime::handle::Handle::block_on_inner
             at /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.40.0/src/runtime/handle.rs:323:9
  19: tokio::runtime::handle::Handle::block_on
             at /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.40.0/src/runtime/handle.rs:302:18
  20: aptos_forge::runner::Forge&lt;F&gt;::run
             at ./testsuite/forge/src/runner.rs:332:50
  21: forge::run_forge_with_changelog
             at ./testsuite/forge-cli/src/main.rs:428:24
  22: forge::main
             at ./testsuite/forge-cli/src/main.rs:331:21
  23: core::ops::function::FnOnce::call_once
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/core/src/ops/function.rs:250:5
  24: std::sys_common::backtrace::__rust_begin_short_backtrace
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/sys_common/backtrace.rs:155:18
  25: std::rt::lang_start::{{closure}}
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/rt.rs:166:18
  26: core::ops::function::impls::&lt;impl core::ops::function::FnOnce&lt;A&gt; for &amp;F&gt;::call_once
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/core/src/ops/function.rs:284:13
  27: std::panicking::try::do_call
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/panicking.rs:552:40
  28: std::panicking::try
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/panicking.rs:516:19
  29: std::panic::catch_unwind
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/panic.rs:146:14
  30: std::rt::lang_start_internal::{{closure}}
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/rt.rs:148:48
  31: std::panicking::try::do_call
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/panicking.rs:552:40
  32: std::panicking::try
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/panicking.rs:516:19
  33: std::panic::catch_unwind
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/panic.rs:146:14
  34: std::rt::lang_start_internal
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/rt.rs:148:20
  35: main
  36: __libc_start_main
  37: _start"/>
        </testcase>
    </testsuite>
</testsuites>
=== END JUNIT ===

Swarm logs can be found here: See fgi output for more information.
{"level":"INFO","source":{"package":"aptos_forge","file":"testsuite/forge/src/backend/k8s/cluster_helper.rs:381"},"thread_name":"main","hostname":"forge-e2e-pr-15864-1738548021-045e772b02bc9da82975ccb32a3620753","timestamp":"2025-02-03T02:11:29.786953Z","message":"Deleting namespace forge-e2e-pr-15864: Some(NamespaceStatus { conditions: None, phase: Some(\"Terminating\") })"}
{"level":"INFO","source":{"package":"aptos_forge","file":"testsuite/forge/src/backend/k8s/cluster_helper.rs:398"},"thread_name":"main","hostname":"forge-e2e-pr-15864-1738548021-045e772b02bc9da82975ccb32a3620753","timestamp":"2025-02-03T02:11:29.786981Z","message":"aptos-node resources for Forge removed in namespace: forge-e2e-pr-15864"}

failures:
    CompositeNetworkTest

test result: FAILED. 0 passed; 1 failed; 0 filtered out

Failed to run tests:
Tests Failed
Error: Tests Failed

Stack backtrace:
   0: anyhow::error::<impl anyhow::Error>::msg
             at /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/anyhow-1.0.89/src/error.rs:85:36
   1: aptos_forge::runner::Forge<F>::run
             at ./testsuite/forge/src/runner.rs:358:13
   2: forge::run_forge_with_changelog
             at ./testsuite/forge-cli/src/main.rs:428:24
   3: forge::main
             at ./testsuite/forge-cli/src/main.rs:331:21
   4: core::ops::function::FnOnce::call_once
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/core/src/ops/function.rs:250:5
   5: std::sys_common::backtrace::__rust_begin_short_backtrace
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/sys_common/backtrace.rs:155:18
   6: std::rt::lang_start::{{closure}}
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/rt.rs:166:18
   7: core::ops::function::impls::<impl core::ops::function::FnOnce<A> for &F>::call_once
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/core/src/ops/function.rs:284:13
   8: std::panicking::try::do_call
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/panicking.rs:552:40
   9: std::panicking::try
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/panicking.rs:516:19
  10: std::panic::catch_unwind
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/panic.rs:146:14
  11: std::rt::lang_start_internal::{{closure}}
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/rt.rs:148:48
  12: std::panicking::try::do_call
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/panicking.rs:552:40
  13: std::panicking::try
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/panicking.rs:516:19
  14: std::panic::catch_unwind
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/panic.rs:146:14
  15: std::rt::lang_start_internal
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/rt.rs:148:20
  16: main
  17: __libc_start_main
  18: _start
Debugging output:
NAME                                    READY   STATUS      RESTARTS   AGE
aptos-node-0-fullnode-eforge107-0       1/1     Running     0          10m
aptos-node-0-validator-0                1/1     Running     0          10m
aptos-node-1-fullnode-eforge107-0       1/1     Running     0          10m
aptos-node-1-validator-0                1/1     Running     0          10m
aptos-node-2-fullnode-eforge107-0       1/1     Running     0          10m
aptos-node-2-validator-0                1/1     Running     0          10m
aptos-node-3-fullnode-eforge107-0       1/1     Running     0          10m
aptos-node-3-validator-0                1/1     Running     0          10m
aptos-node-4-fullnode-eforge107-0       1/1     Running     0          10m
aptos-node-4-validator-0                1/1     Running     0          10m
aptos-node-5-validator-0                1/1     Running     0          10m
aptos-node-6-validator-0                1/1     Running     0          10m
forge-testnet-deployer-mk8sd            0/1     Completed   0          10m
genesis-aptos-genesis-eforge107-gdcsh   0/1     Completed   0          10m

github-actions · 2025-02-03T02:12:42Z

✅ Forge suite `compat` success on `60f7ca8827f5d64a148c3b163dc4126b0879279b` ==> `045e772b02bc9da82975ccb32a362075357e6879`

Compatibility test results for 60f7ca8827f5d64a148c3b163dc4126b0879279b ==> 045e772b02bc9da82975ccb32a362075357e6879 (PR)
1. Check liveness of validators at old version: 60f7ca8827f5d64a148c3b163dc4126b0879279b
compatibility::simple-validator-upgrade::liveness-check : committed: 12221.25 txn/s, latency: 2549.41 ms, (p50: 2600 ms, p70: 2700, p90: 3000 ms, p99: 3300 ms), latency samples: 402820
2. Upgrading first Validator to new version: 045e772b02bc9da82975ccb32a362075357e6879
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 3231.12 txn/s, latency: 9081.91 ms, (p50: 9800 ms, p70: 11200, p90: 11900 ms, p99: 12000 ms), latency samples: 70580
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 3279.90 txn/s, latency: 10513.93 ms, (p50: 11500 ms, p70: 11800, p90: 12100 ms, p99: 12100 ms), latency samples: 126800
3. Upgrading rest of first batch to new version: 045e772b02bc9da82975ccb32a362075357e6879
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 1174.69 txn/s, submitted: 1174.99 txn/s, expired: 0.29 txn/s, latency: 8925.81 ms, (p50: 9500 ms, p70: 11000, p90: 11700 ms, p99: 11900 ms), latency samples: 71882
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 3290.26 txn/s, latency: 10489.89 ms, (p50: 11500 ms, p70: 11600, p90: 11700 ms, p99: 11800 ms), latency samples: 127000
4. upgrading second batch to new version: 045e772b02bc9da82975ccb32a362075357e6879
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 5950.29 txn/s, latency: 5077.72 ms, (p50: 5800 ms, p70: 6000, p90: 6800 ms, p99: 6900 ms), latency samples: 113700
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 5877.89 txn/s, latency: 5813.62 ms, (p50: 6100 ms, p70: 6800, p90: 7000 ms, p99: 7300 ms), latency samples: 201860
5. check swarm health
Compatibility test for 60f7ca8827f5d64a148c3b163dc4126b0879279b ==> 045e772b02bc9da82975ccb32a362075357e6879 passed
Test Ok

hariria

LGTM!

hariria · 2025-02-03T17:43:59Z

consensus/src/consensus_observer/observer/consensus_observer.rs

@@ -416,13 +416,15 @@ impl ConsensusObserver {

        // Verify the block payload digests
        if let Err(error) = block_payload.verify_payload_digests() {
+            // Log the error and update the invalid message counter
            error!(
                LogSchema::new(LogEntry::ConsensusObserver).message(&format!(


I wonder if including some information about the peer might be helpful here

[Consensus Observer] Small improvements to message metrics.

045e772

JoshLind added the CICD:run-e2e-tests when this label is present github actions will run all land-blocking e2e tests from the PR label Feb 3, 2025

This comment has been minimized.

Sign in to view

JoshLind marked this pull request as ready for review February 3, 2025 14:09

JoshLind requested review from zekun000, sasha8 and ibalajiarun as code owners February 3, 2025 14:09

JoshLind requested review from bchocho and hariria February 3, 2025 14:09

JoshLind mentioned this pull request Feb 3, 2025

[Consensus Observer] Add boilerplate for block with window messages. #15869

Open

hariria approved these changes Feb 3, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Consensus Observer] Small improvements to message metrics. #15864

[Consensus Observer] Small improvements to message metrics. #15864

JoshLind commented Feb 1, 2025 •

edited

Loading

trunk-io bot commented Feb 1, 2025 •

edited

Loading

This comment has been minimized.

This comment has been minimized.

github-actions bot commented Feb 3, 2025

github-actions bot commented Feb 3, 2025

hariria left a comment

hariria Feb 3, 2025

[Consensus Observer] Small improvements to message metrics. #15864

Are you sure you want to change the base?

[Consensus Observer] Small improvements to message metrics. #15864

Conversation

JoshLind commented Feb 1, 2025 • edited Loading

Description

Testing Plan

trunk-io bot commented Feb 1, 2025 • edited Loading

This comment has been minimized.

This comment has been minimized.

github-actions bot commented Feb 3, 2025

❌ Forge suite realistic_env_max_load failure on 045e772b02bc9da82975ccb32a362075357e6879

github-actions bot commented Feb 3, 2025

✅ Forge suite compat success on 60f7ca8827f5d64a148c3b163dc4126b0879279b ==> 045e772b02bc9da82975ccb32a362075357e6879

hariria left a comment

Choose a reason for hiding this comment

hariria Feb 3, 2025

Choose a reason for hiding this comment

JoshLind commented Feb 1, 2025 •

edited

Loading

trunk-io bot commented Feb 1, 2025 •

edited

Loading

❌ Forge suite `realistic_env_max_load` failure on `045e772b02bc9da82975ccb32a362075357e6879`

✅ Forge suite `compat` success on `60f7ca8827f5d64a148c3b163dc4126b0879279b` ==> `045e772b02bc9da82975ccb32a362075357e6879`