Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typos Fixes #15867

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions api/doc/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -110,8 +110,8 @@ This section is dedicated to the finer details of the API change, but we include
- Epoch is returned as a U64 (the string wrapper), not a u64. The v0 API received this change too, as the previous behavior was inconsistent and potentially incorrect.
- `/transactions/simulate` returns a `UserTransaction` now, not just a `Transaction`. The user can only ever submit a user transaction to this endpoint, so it can only ever return a user transaction.
- All docs in the spec that incorrectly used a 16 byte address have been updated.
- MoveTypes are now returned as structured structs instead of strings. To deal with some types that we don't have proper parsing for, e.g. generic type params, a new “unparseable” variant has been added. This ensures the response from the API can actually be deserialized.
- MoveValue has received the same treatment, minus the unparseable stuff.
- MoveTypes are now returned as structured structs instead of strings. To deal with some types that we don't have proper parsing for, e.g. generic type params, a new “unparsable” variant has been added. This ensures the response from the API can actually be deserialized.
- MoveValue has received the same treatment, minus the unparsable stuff.
- Some snake casing is different, e.g. ed25519 became ed_25519 (proper snake casing).
- U64 and U128 have been used throughout every endpoint. There were a couple of places in v0 where we should've been using it but weren't, e.g. paging params.
- The `v1` API runs on a separate port (where the OS selects a free port) behind a reverse proxy running within the node. This works fine with our source and docker based deployments. This is only temporary while we host both APIs.
Expand Down
2 changes: 1 addition & 1 deletion aptos-move/aptos-vm-logging/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ pub fn flush_speculative_logs(num_to_flush: usize) {
}
}

/// Clear speculative logs recorded for a specific transction, useful when transaction
/// Clear speculative logs recorded for a specific transaction, useful when transaction
/// execution fails validation and aborts - setting stage for the re-execution.
pub fn clear_speculative_txn_logs(txn_idx: usize) {
if speculation_disabled() {
Expand Down
2 changes: 1 addition & 1 deletion aptos-move/aptos-vm/src/block_executor/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ impl AptosTransactionOutput {
.take()
.expect("Output must be set")
.into_transaction_output()
.expect("Transaction output is not alerady materialized"),
.expect("Transaction output is not already materialized"),
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion aptos-move/framework/aptos-token/doc/token.md
Original file line number Diff line number Diff line change
Expand Up @@ -3045,7 +3045,7 @@ Mutate the token_properties of one token.
<b>assert</b>!(<a href="../../aptos-framework/../aptos-stdlib/doc/table.md#0x1_table_contains">table::contains</a>(all_token_data, token_id.token_data_id), <a href="../../aptos-framework/../aptos-stdlib/../move-stdlib/doc/error.md#0x1_error_not_found">error::not_found</a>(<a href="token.md#0x3_token_ETOKEN_DATA_NOT_PUBLISHED">ETOKEN_DATA_NOT_PUBLISHED</a>));
<b>let</b> token_data = <a href="../../aptos-framework/../aptos-stdlib/doc/table.md#0x1_table_borrow_mut">table::borrow_mut</a>(all_token_data, token_id.token_data_id);

// <b>if</b> default property is mutatable, <a href="token.md#0x3_token">token</a> property is alwasy mutable
// <b>if</b> default property is mutatable, <a href="token.md#0x3_token">token</a> property is always mutable
// we only need <b>to</b> check <a href="token.md#0x3_token_TOKEN_PROPERTY_MUTABLE">TOKEN_PROPERTY_MUTABLE</a> when default property is immutable
<b>if</b> (!token_data.mutability_config.properties) {
<b>assert</b>!(
Expand Down
Loading