Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[aptos-workspace-server] add ability to listen for a stop command + bump aptos CLI version to 6.1.1 #15898

Merged
merged 1 commit into from
Feb 6, 2025

Conversation

vgao1996
Copy link
Contributor

@vgao1996 vgao1996 commented Feb 6, 2025

This adds to aptos-workspace-server the ability to listen for a stop command from stdin so to allow external programs to conveniently trigger a graceful shutdown. This is especially needed on Windows, where it is not possible to send a SIGINT to just a child process.

This also bumps the CLI version to 6.1.1.

Copy link

trunk-io bot commented Feb 6, 2025

⏱️ 29m total CI duration on this PR
Job Cumulative Duration Recent Runs
rust-doc-tests 7m 🟩
check-dynamic-deps 5m 🟩🟩
execution-performance / test-target-determinator 5m 🟩
test-target-determinator 4m 🟩
rust-cargo-deny 4m 🟩🟩
fetch-last-released-docker-image-tag 2m 🟩
general-lints 51s 🟩🟩
semgrep/ci 42s 🟩🟩
file_change_determinator 18s 🟩🟩
file_change_determinator 11s 🟩
execution-performance / single-node-performance 9s 🟩
permission-check 4s 🟩🟩
permission-check 4s 🟩🟩
permission-check 2s 🟩
determine-docker-build-metadata 2s 🟩

🚨 1 job on the last run was significantly faster/slower than expected

Job Duration vs 7d avg Delta
execution-performance / single-node-performance 9s 15m -99%

settingsfeedbackdocs ⋅ learn more about trunk.io

@vgao1996 vgao1996 enabled auto-merge (squash) February 6, 2025 21:39

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

github-actions bot commented Feb 6, 2025

✅ Forge suite realistic_env_max_load success on 8b4d2770354155aa24e7c9d00f560a30745efd1d

two traffics test: inner traffic : committed: 13169.17 txn/s, submitted: 13174.59 txn/s, expired: 5.42 txn/s, latency: 3015.01 ms, (p50: 2600 ms, p70: 3300, p90: 4200 ms, p99: 5400 ms), latency samples: 5007220
two traffics test : committed: 99.97 txn/s, latency: 2604.35 ms, (p50: 2200 ms, p70: 2800, p90: 4200 ms, p99: 5200 ms), latency samples: 1940
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 0.827, avg: 0.401", "ConsensusProposalToOrdered: max: 0.314, avg: 0.307", "ConsensusOrderedToCommit: max: 0.961, avg: 0.659", "ConsensusProposalToCommit: max: 1.271, avg: 0.966"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 1.48s no progress at version 24426 (avg 0.20s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 1.03s no progress at version 2082871 (avg 0.91s) [limit 16].
Test Ok

Copy link
Contributor

github-actions bot commented Feb 6, 2025

✅ Forge suite framework_upgrade success on 255673e8f2757ed8634a7d65d7aca11de7016cde ==> 8b4d2770354155aa24e7c9d00f560a30745efd1d

Compatibility test results for 255673e8f2757ed8634a7d65d7aca11de7016cde ==> 8b4d2770354155aa24e7c9d00f560a30745efd1d (PR)
Upgrade the nodes to version: 8b4d2770354155aa24e7c9d00f560a30745efd1d
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1455.35 txn/s, submitted: 1460.93 txn/s, failed submission: 5.58 txn/s, expired: 5.58 txn/s, latency: 1976.70 ms, (p50: 1800 ms, p70: 2400, p90: 3300 ms, p99: 4500 ms), latency samples: 130340
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1652.43 txn/s, submitted: 1656.39 txn/s, failed submission: 3.97 txn/s, expired: 3.97 txn/s, latency: 1742.64 ms, (p50: 1500 ms, p70: 1800, p90: 2700 ms, p99: 3900 ms), latency samples: 149940
5. check swarm health
Compatibility test for 255673e8f2757ed8634a7d65d7aca11de7016cde ==> 8b4d2770354155aa24e7c9d00f560a30745efd1d passed
Upgrade the remaining nodes to version: 8b4d2770354155aa24e7c9d00f560a30745efd1d
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1728.22 txn/s, submitted: 1733.13 txn/s, failed submission: 4.91 txn/s, expired: 4.91 txn/s, latency: 1682.65 ms, (p50: 1500 ms, p70: 1800, p90: 2400 ms, p99: 3300 ms), latency samples: 154780
Test Ok

Copy link
Contributor

github-actions bot commented Feb 6, 2025

✅ Forge suite compat success on 255673e8f2757ed8634a7d65d7aca11de7016cde ==> 8b4d2770354155aa24e7c9d00f560a30745efd1d

Compatibility test results for 255673e8f2757ed8634a7d65d7aca11de7016cde ==> 8b4d2770354155aa24e7c9d00f560a30745efd1d (PR)
1. Check liveness of validators at old version: 255673e8f2757ed8634a7d65d7aca11de7016cde
compatibility::simple-validator-upgrade::liveness-check : committed: 11988.41 txn/s, latency: 2634.78 ms, (p50: 2700 ms, p70: 2800, p90: 3100 ms, p99: 4100 ms), latency samples: 399540
2. Upgrading first Validator to new version: 8b4d2770354155aa24e7c9d00f560a30745efd1d
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 3268.80 txn/s, latency: 9044.53 ms, (p50: 9700 ms, p70: 10800, p90: 11500 ms, p99: 11600 ms), latency samples: 72960
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 3251.92 txn/s, latency: 10575.74 ms, (p50: 11600 ms, p70: 11800, p90: 11900 ms, p99: 12000 ms), latency samples: 126780
3. Upgrading rest of first batch to new version: 8b4d2770354155aa24e7c9d00f560a30745efd1d
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 3190.89 txn/s, latency: 9183.47 ms, (p50: 9800 ms, p70: 11300, p90: 12100 ms, p99: 12200 ms), latency samples: 69880
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 3228.33 txn/s, latency: 10689.73 ms, (p50: 11600 ms, p70: 12200, p90: 12300 ms, p99: 12300 ms), latency samples: 126460
4. upgrading second batch to new version: 8b4d2770354155aa24e7c9d00f560a30745efd1d
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 6085.72 txn/s, latency: 4986.87 ms, (p50: 5800 ms, p70: 6100, p90: 6300 ms, p99: 6500 ms), latency samples: 114620
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 5898.82 txn/s, latency: 5745.97 ms, (p50: 6300 ms, p70: 6400, p90: 6500 ms, p99: 6600 ms), latency samples: 203420
5. check swarm health
Compatibility test for 255673e8f2757ed8634a7d65d7aca11de7016cde ==> 8b4d2770354155aa24e7c9d00f560a30745efd1d passed
Test Ok

Copy link
Contributor

@vineethk vineethk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be useful to have the testing section in the PR description say what kind of testing was performed.

I assume it was manual testing in this case.

@vgao1996 vgao1996 merged commit 80160b5 into aptos-labs:main Feb 6, 2025
88 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants