Make NodeClient satisfy AptosRpcClient interface #124
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
AptosRpcClient
interface is supposed to be implemented byNodeClient
:But doesn't actually satisfy the interface due to two methods:
I wasn't sure if you'd want to break compatibility by renaming the method and added a new method
NodeAPIHealthCheck
and kept the old oneNodeHealthCheck
while marking it as deprecated.NodeClient
already accepted theTransactionSigner
interface and I lifted its usage to theAptosRpcClient
interface. This should not break compatibility as*Account
can still be passed.Test Plan
Ran all tests with
go test ./...
Related Links
These interfaces were requested in #94 and added in #97