-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add temperature change card in site dashboard #1046
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Build succeeded and deployed at https://aqualink-app-1046.surge.sh |
@@ -42,7 +43,7 @@ import Map from './Map'; | |||
import SketchFab from './SketchFab'; | |||
import FeaturedMedia from './FeaturedMedia'; | |||
import Satellite from './Satellite'; | |||
import Sensor from './Sensor'; | |||
// import Sensor from './Sensor'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that we still want to display the Sensor card when there is a spotter/buoy with live data for that site
Hi @K-Markopoulos, I think many of the changes look great. However, I'd like to add some more information about the card. We would like the number in color to be calculated by the past 7 days compared to the 7 days before that. As Eric mentioned, this card should be shown if there's no buoy data available. If a site has water quality data and no buoy, we should still display the heat stress card together with the water quality card like before. I think we would want to show the temperature and one decimal number (ex. 22.6°C, just like you've done in the example). I think this calculation would be the most accurate to calculate the past 7 days compared to the 7 days before that. Example: |
@Caesarh97 Thanks for the detailed explanation, I've updated the logic. Please let me know if anything seems off. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ This pull request was sent to the PullRequest network for review. Expert reviewers are now being matched to your request based on the code's requirements. Stay tuned!
What to expect from this code review:
- Comments posted to any areas of potential concern or improvement.
- Detailed feedback or actions needed to resolve issues that are found.
- Turnaround times vary, but we aim to be swift.
@K-Markopoulos you can click here to see the review status or cancel the code review job.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PullRequest Breakdown
Reviewable lines of change
+ 944
- 411
83% Jest Snapshot (tests)
13% TSX
4% TSX (tests)
1% TypeScript
Generated lines of change
+ 1
- 0
Type of change
Feature - These changes are adding a new feature or improvement to existing code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@K-Markopoulos That looks great! Thank you! |
Issue #1022
Add 7-days temperature change card in place of Buoy Observation card when site doesn't have a spotter.
satelliteTemperature
from site'sdailyData
: avg of 7 last days minus avg of 8-14 days back