Add Reef check surveys #1060
Add Reef check surveys #1060
Conversation
K-Markopoulos
force-pushed
the
reef-check-survey-page
branch
from
cf1f81c to
5781f20
Compare
|
Build succeeded and deployed at https://aqualink-app-1060.surge.sh |
![pullrequest[bot]](https://avatars.githubusercontent.com/in/3434?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ This pull request was sent to the PullRequest network for review. Expert reviewers are now being matched to your request based on the code's requirements. Stay tuned!
What to expect from this code review:
- Comments posted to any areas of potential concern or improvement.
- Detailed feedback or actions needed to resolve issues that are found.
- Turnaround times vary, but we aim to be swift.
@K-Markopoulos you can click here to see the review status or cancel the code review job.
There was a problem hiding this comment.
PullRequest Breakdown
Reviewable lines of change
+ 1,889
- 35
47% TSX
36% TypeScript
17% TSX (tests)
<1% JSON
<1% OtherType of change
Feature - These changes are adding a new feature or improvement to existing code.
| 1 Message | |
|---|---|
| Due to its size, this pull request will likely have a little longer turnaround time and will probably require multiple passes from our reviewers. |
There was a problem hiding this comment.
I've given this MR a quick first pass, and noticed an issue, noted inline. Second pass to follow, shortly.
Reviewed with ❤️ by PullRequest
There was a problem hiding this comment.
I've completed my second pass, and noticed just one additional issue, besides the smattering of TODO comments.
Reviewed with ❤️ by PullRequest
packages/website/src/routes/SiteRoutes/ReefCheckSurveys/ReefCheckSurveySummary.tsx
Show resolved
Hide resolved
* Hide previous data while loading * Add reef check surveys in Sites survey list * Add default value to surveyList * Add tests * Add react-scan for performance profiling (#1065) * Use available width for timeline items * Format impact count and show all rows * Fix timeline styling issue * Scroll to top on route change * Update tests * Update index.tsx * Filter out empty rows * Fix hasSpotter when there is topTemp only (#1068) * Update index.tsx * Update index.tsx * [Snyk] Fix for 3 vulnerabilities (#1067) The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-TAR-6476909 - https://snyk.io/vuln/SNYK-JS-INFLIGHT-6095116 - https://snyk.io/vuln/SNYK-JS-AXIOS-6671926 Co-authored-by: snyk-bot <[email protected]> * Filter out empty rows for Fish and Invertebrates * Fix timeline skeleton * Show invertebrates header inline --------- Co-authored-by: ericboucher <[email protected]> Co-authored-by: snyk-bot <[email protected]>
| .sort( | ||
| (a, b) => b.s1 + b.s2 + b.s3 + b.s4 - (a.s1 + a.s2 + a.s3 + a.s4), | ||
| ) ?? []; |
There was a problem hiding this comment.
should we create a util for this? Maybe we could DRY the code a bit for the tables, wdyt?
There was a problem hiding this comment.
Yes good idea. Do you have any other suggestion? I tried to keep it DRY by creating the reusable components.
packages/website/src/routes/SiteRoutes/ReefCheckSurveys/ReefCheckSurveySummary.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Due to inactivity, PullRequest has cancelled this review job. You can reactivate the code review job from the PullRequest dashboard.
Note: requires backend changes from #1052 to work.
Add reef check survey page in UI. Designs
Next steps for this PR:
Reconsider details layout (from flex to table)We keep the flex with media queries forcolumn-count