Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ppt unit for hui #1062

Merged
merged 2 commits into from
Nov 28, 2024
Merged

Use ppt unit for hui #1062

merged 2 commits into from
Nov 28, 2024

Conversation

ericboucher
Copy link
Member

No description provided.

Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ This pull request was sent to the PullRequest network for review. Expert reviewers are now being matched to your request based on the code's requirements. Stay tuned!

What to expect from this code review:
  • Comments posted to any areas of potential concern or improvement.
  • Detailed feedback or actions needed to resolve issues that are found.
  • Turnaround times vary, but we aim to be swift.

Check the status or cancel PullRequest code review here.

Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PullRequest Breakdown

Reviewable lines of change

+ 5
- 5

60% Jest Snapshot (tests)
40% TypeScript

Type of change

Minor Update - These changes appear to be a minor update to existing functionality and features.
1 Message
📚 It looks like the description for this pull request is either blank or very short. Adding a high-level summary will help our reviewers provide better feedback. Feel free to include questions for PullRequest reviewers and make specific feedback requests.

Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work here. I don't have any concerns with these changes.

Image of Graham C Graham C


Reviewed with ❤️ by PullRequest

@ericboucher ericboucher linked an issue Nov 28, 2024 that may be closed by this pull request
Copy link

Build succeeded and deployed at https://aqualink-app-1062.surge.sh
(hash 6d017fc deployed at 2024-11-28T10:11:40)

@ericboucher ericboucher merged commit 399d7d8 into master Nov 28, 2024
3 checks passed
@ericboucher ericboucher deleted the ppt-hui branch November 28, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change HUI measurement for salinity to ppt
2 participants