Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add react-scan for performance profiling #1065

Merged
merged 1 commit into from
Dec 4, 2024
Merged

Conversation

K-Markopoulos
Copy link
Collaborator

Screencast.from.03-12-2024.07.40.32.webm

@K-Markopoulos K-Markopoulos self-assigned this Dec 3, 2024
Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ This pull request was sent to the PullRequest network for review. Expert reviewers are now being matched to your request based on the code's requirements. Stay tuned!

What to expect from this code review:
  • Comments posted to any areas of potential concern or improvement.
  • Detailed feedback or actions needed to resolve issues that are found.
  • Turnaround times vary, but we aim to be swift.

@K-Markopoulos you can click here to see the review status or cancel the code review job.

Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PullRequest Breakdown

Reviewable lines of change

+ 5
- 0

80% Markdown
20% JSON

Type of change

Minor Update - These changes appear to be a minor update to existing functionality and features.

Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work here. I don't have any concerns with these changes.

Image of Graham C Graham C


Reviewed with ❤️ by PullRequest

Copy link

github-actions bot commented Dec 3, 2024

Build succeeded and deployed at https://aqualink-app-1065.surge.sh
(hash c048480 deployed at 2024-12-03T17:45:08)

Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PullRequest reviewed the updates made to #1065 since our last review was posted. This includes comments that have been posted by non-PullRequest reviewers. No further issues were found.

Reviewed by:

Image of Graham C Graham C

@ericboucher ericboucher merged commit 5e72bef into master Dec 4, 2024
3 checks passed
@ericboucher ericboucher deleted the add-react-scan branch December 4, 2024 20:13
ericboucher added a commit that referenced this pull request Dec 20, 2024
* Hide previous data while loading

* Add reef check surveys in Sites survey list

* Add default value to surveyList

* Add tests

* Add react-scan for performance profiling (#1065)

* Use available width for timeline items

* Format impact count and show all rows

* Fix timeline styling issue

* Scroll to top on route change

* Update tests

* Update index.tsx

* Filter out empty rows

* Fix hasSpotter when there is topTemp only (#1068)

* Update index.tsx

* Update index.tsx

* [Snyk] Fix for 3 vulnerabilities (#1067)

The following vulnerabilities are fixed with an upgrade:
- https://snyk.io/vuln/SNYK-JS-TAR-6476909
- https://snyk.io/vuln/SNYK-JS-INFLIGHT-6095116
- https://snyk.io/vuln/SNYK-JS-AXIOS-6671926

Co-authored-by: snyk-bot <[email protected]>

* Filter out empty rows for Fish and Invertebrates

* Fix timeline skeleton

* Show invertebrates header inline

---------

Co-authored-by: ericboucher <[email protected]>
Co-authored-by: snyk-bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants