Add water quality data to site model and use it to power site filter

[yaodingyd]

fix #1026
/claim #1026

Add waterQuality to site model that would include list of water quality metrics.

The logics to determine water quality metrics is from

aqualink-app/packages/website/src/common/SiteDetails/index.tsx

Lines 157 to 174 in 56dbb9c

	const combinedArray = [...forecastData, ...latestData];
	const parsedData = parseLatestData(combinedArray);
	const hasSpotter = Boolean(parsedData.bottomTemperature);
	const hasSonde =
	sondeMetrics.filter((x) => Boolean(parsedData[x])).length >=
	MINIMUM_SONDE_METRICS_TO_SHOW_CARD;
	const hasHUI =
	latestData.some((x) => x.source === 'hui') ||
	sourceWithinDataRangeInterval(
	acceptHUIInterval,
	'hui',
	timeSeriesRange,
	);
	setHasSondeData(hasSonde);
	setHasSpotterData(hasSpotter);
	setHasHUIData(hasHUI);

which looks at LatestData entity (and forecast data, omitted by now) and check if they have hui source or enough sonde metrics.

If this is the correct direction, I can work on a follow up to remove the checks in frontend and consolidate to the backend, so we have single source of truth. This also avoid multiple data fetching to get water quality data

[pullrequest]

✅ This pull request was sent to the PullRequest network for review. Expert reviewers are now being matched to your request based on the code's requirements. Stay tuned!

What to expect from this code review:

• Comments posted to any areas of potential concern or improvement.
• Detailed feedback or actions needed to resolve issues that are found.
• Turnaround times vary, but we aim to be swift.

---

@yaodingyd you can click here to see the review status or cancel the code review job.

[pullrequest]

PullRequest Breakdown

Reviewable lines of change

+ 70
- 1

85% TypeScript
15% Jest Snapshot (tests)

Type of change

Feature - These changes are adding a new feature or improvement to existing code.

[github-actions]

Build succeeded and deployed at https://aqualink-app-1076.surge.sh
(hash d7361e9 deployed at 2025-01-23T16:00:57)

[pullrequest]

This pull request would normally not be reviewed by PullRequest because the pull request is a draft; however since a review was already requested, it is currently being reviewed by the PullRequest network. If you would like to cancel it, you can do so manually from the PullRequest dashboard.

[pullrequest]

Nice work here. I don't have any concerns with these changes, security or otherwise.

Graham C

---

Reviewed with ❤️ by PullRequest

[ericboucher]

Would it be easy to do this inline instead of for the whole file?

[pullrequest]

PullRequest reviewed the updates made to #1076 up until the latest commit (a17524a). No further issues were found.

Reviewed by:

Graham C

[pullrequest]

Due to inactivity, PullRequest has cancelled this review job. You can reactivate the code review job from the PullRequest dashboard.

[K-Markopoulos]

has prefix is usually used for functions that return boolean, but this one returns a map. It might be better to rename or return a boolean instead of the map, since we are only interested in a specific site and not all the map.

[K-Markopoulos]

We are looking for hui and sonde sources so let's specify that in the where clause to only get these. Also, it will be more performant to filter by siteId here and not load the whole table (or view) in memory.

[K-Markopoulos]

We can use the metrics in snake_case as they are stored in DB instead of writing them in camel case and converting the metric in each iteration. We can use Metric enum directly.