Admin - Extend site edit functionality

packages/api/migration/1702565409448-AddContactInformationColumn.ts

@@ -0,0 +1,19 @@
+import { MigrationInterface, QueryRunner } from 'typeorm';
+
+export class AddContactInformationColumn1702565409448
+  implements MigrationInterface
+{
+  name = 'AddContactInformationColumn1702565409448';
+
+  public async up(queryRunner: QueryRunner): Promise<void> {
+    await queryRunner.query(
+      `ALTER TABLE "site" ADD "contact_information" character varying`,
+    );
+  }
+
+  public async down(queryRunner: QueryRunner): Promise<void> {
+    await queryRunner.query(
+      `ALTER TABLE "site" DROP COLUMN "contact_information"`,
+    );
+  }
+}

packages/api/src/collections/collections.spec.ts

@@ -177,6 +177,7 @@ export const collectionTests = () => {
           'createdAt',
           'updatedAt',
           'spotterApiToken',
+          'contactInformation',
         ),
       );
       expect(sortedSites[1]).toMatchObject(
@@ -186,6 +187,7 @@ export const collectionTests = () => {
           'createdAt',
           'updatedAt',
           'spotterApiToken',
+          'contactInformation',
         ),
       );
 
@@ -231,7 +233,14 @@ export const collectionTests = () => {
 
     const sortedSites = sortBy(rsp.body.sites, (o) => o.name);
     expect(sortedSites[0]).toMatchObject(
-      omit(athensSite, 'applied', 'createdAt', 'updatedAt', 'spotterApiToken'),
+      omit(
+        athensSite,
+        'applied',
+        'createdAt',
+        'updatedAt',
+        'spotterApiToken',
+        'contactInformation',
+      ),
     );
     expect(sortedSites[1]).toMatchObject(
       omit(
@@ -240,10 +249,18 @@ export const collectionTests = () => {
         'createdAt',
         'updatedAt',
         'spotterApiToken',
+        'contactInformation',
       ),
     );
     expect(sortedSites[2]).toMatchObject(
-      omit(floridaSite, 'applied', 'createdAt', 'updatedAt', 'spotterApiToken'),
+      omit(
+        floridaSite,
+        'applied',
+        'createdAt',
+        'updatedAt',
+        'spotterApiToken',
+        'contactInformation',
+      ),
     );
 
     const athensLatestData = getLatestData(athensTimeSeries);

packages/api/src/monitoring/dto/get-sites-overview.dto.ts

@@ -1,19 +1,12 @@
 import { ApiProperty } from '@nestjs/swagger';
 import { Type } from 'class-transformer';
-import {
-  IsEmail,
-  IsEnum,
-  IsNumber,
-  IsOptional,
-  Validate,
-} from 'class-validator';
+import { IsEmail, IsEnum, IsOptional, Validate } from 'class-validator';
 import { Site, SiteStatus } from 'sites/sites.entity';
 import { EntityExists } from 'validations/entity-exists.constraint';
 
-export class GetSitesOverview {
+export class GetSitesOverviewDto {
   @ApiProperty({ example: 42 })
   @IsOptional()
-  @IsNumber()
   @Validate(EntityExists, [Site])
   siteId?: number;
 

packages/api/src/monitoring/monitoring.controller.ts

@@ -4,6 +4,7 @@ import { Auth } from 'auth/auth.decorator';
 import { AuthRequest } from 'auth/auth.types';
 import { AdminLevel } from 'users/users.entity';
 import { GetMonitoringStatsDto } from './dto/get-monitoring-stats.dto';
+import { GetSitesOverviewDto } from './dto/get-sites-overview.dto';
 import { PostMonitoringMetricDto } from './dto/post-monitoring-metric.dto';
 import { MonitoringService } from './monitoring.service';
 
@@ -58,7 +59,14 @@ export class MonitoringController {
   @Get('sites-overview')
   @ApiOperation({ summary: 'Get Aqualink overview' })
   @Auth(AdminLevel.SuperAdmin)
-  getSitesOverview(@Query() getSitesOverviewDto: GetMonitoringStatsDto) {
+  getSitesOverview(@Query() getSitesOverviewDto: GetSitesOverviewDto) {
     return this.monitoringService.SitesOverview(getSitesOverviewDto);
   }
+
+  @Get('sites-status')
+  @ApiOperation({ summary: "Get sites' status" })
+  @Auth(AdminLevel.SuperAdmin)
+  getSitesStatus() {
+    return this.monitoringService.getSitesStatus();
+  }
 }

packages/api/src/monitoring/monitoring.service.ts

@@ -12,7 +12,7 @@ import { LatestData } from 'time-series/latest-data.entity';
 import { IsNull, Not, Repository } from 'typeorm';
 import { AdminLevel, User } from 'users/users.entity';
 import { getDefaultDates } from 'utils/dates';
-import { GetSitesOverview } from './dto/get-sites-overview.dto';
+import { GetSitesOverviewDto } from './dto/get-sites-overview.dto';
 import { GetMonitoringStatsDto } from './dto/get-monitoring-stats.dto';
 import { PostMonitoringMetricDto } from './dto/post-monitoring-metric.dto';
 import { Monitoring } from './monitoring.entity';
@@ -172,7 +172,7 @@ export class MonitoringService {
       : null;
 
     if (spotterSite === null && spotterId) {
-      throw new BadRequestException('Invalid parameter: spotterId');
+      throw new BadRequestException('Invalid value for parameter: spotterId');
     }
 
     const querySiteIds = siteIds || [spotterSite!.id];
@@ -244,7 +244,7 @@ export class MonitoringService {
     adminUsername,
     organization,
     status,
-  }: GetSitesOverview) {
+  }: GetSitesOverviewDto) {
     const latestDataSubQuery = this.latestDataRepository
       .createQueryBuilder('latest_data')
       .select(
@@ -257,7 +257,7 @@ export class MonitoringService {
     const surveysCountSubQuery = this.surveyRepository
       .createQueryBuilder('survey')
       .select('survey.site_id', 'site_id')
-      .addSelect('COUNT(*)', 'surveysCount')
+      .addSelect('COUNT(*)', 'count')
       .groupBy('survey.site_id');
 
     const baseQuery = this.siteRepository
@@ -273,7 +273,8 @@ export class MonitoringService {
       .addSelect('site.video_stream', 'videoStream')
       .addSelect('site.updated_at', 'updatedAt')
       .addSelect('latest_data.timestamp', 'lastDataReceived')
-      .addSelect('COALESCE("surveys_count"."surveysCount", 0)', 'surveysCount')
+      .addSelect('COALESCE(surveys_count.count, 0)', 'surveysCount')
+      .addSelect('site.contact_information', 'contactInformation')
       .leftJoin(
         'users_administered_sites_site',
         'uass',
@@ -332,8 +333,28 @@ export class MonitoringService {
       .addGroupBy('site.video_stream')
       .addGroupBy('site.updated_at')
       .addGroupBy('latest_data.timestamp')
-      .addGroupBy('"surveys_count"."surveysCount"');
+      .addGroupBy('surveys_count.count')
+      .addGroupBy('site.contact_information');
 
     return ret.getRawMany();
   }
+
+  getSitesStatus() {
+    return this.siteRepository
+      .createQueryBuilder('site')
+      .select('COUNT(*)', 'totalSites')
+      .addSelect("COUNT(*) FILTER (WHERE site.status = 'deployed')", 'deployed')
+      .addSelect('COUNT(*) FILTER (WHERE site.display)', 'displayed')
+      .addSelect(
+        "COUNT(*) FILTER (WHERE site.status = 'maintenance')",
+        'maintenance',
+      )
+      .addSelect("COUNT(*) FILTER (WHERE site.status = 'shipped')", 'shipped')
+      .addSelect(
+        "COUNT(*) FILTER (WHERE site.status = 'end_of_life')",
+        'endOfLife',
+      )
+      .addSelect("COUNT(*) FILTER (WHERE site.status = 'lost')", 'lost')
+      .getRawOne();
+  }
 }

packages/api/src/monitoring/monitoring.spec.ts

@@ -117,5 +117,23 @@ export const monitoringTests = () => {
     expect(rsp.body[0].updatedAt).toBeDefined();
     expect(rsp.body[0].lastDataReceived).toBeDefined();
     expect(rsp.body[0].surveysCount).toBeDefined();
+    expect(rsp.body[0].contactInformation).toBeDefined();
+  });
+
+  it('GET /sites-status', async () => {
+    mockExtractAndVerifyToken(adminFirebaseUserMock);
+    const rsp = await request(app.getHttpServer())
+      .get('/monitoring/sites-status')
+      .send();
+
+    expect(rsp.status).toBe(200);
+
+    expect(rsp.body.totalSites).toBeDefined();
+    expect(rsp.body.deployed).toBeDefined();
+    expect(rsp.body.displayed).toBeDefined();
+    expect(rsp.body.maintenance).toBeDefined();
+    expect(rsp.body.shipped).toBeDefined();
+    expect(rsp.body.endOfLife).toBeDefined();
+    expect(rsp.body.lost).toBeDefined();
   });
 };

packages/api/src/sites/dto/update-site.dto.ts

@@ -10,9 +10,11 @@ import {
   IsLongitude,
   IsObject,
   ValidateNested,
+  IsEnum,
 } from 'class-validator';
-import { Type } from 'class-transformer';
+import { Transform, Type } from 'class-transformer';
 import { ApiProperty } from '@nestjs/swagger';
+import { SiteStatus } from 'sites/sites.entity';
 import { EntityExists } from '../../validations/entity-exists.constraint';
 import { Region } from '../../regions/regions.entity';
 import { User } from '../../users/users.entity';
@@ -49,7 +51,7 @@ export class UpdateSiteDto {
 
   @IsOptional()
   @IsUrl()
-  readonly videoStream?: string;
+  readonly videoStream?: string | null;
 
   @ApiProperty({ example: 1 })
   @IsOptional()
@@ -82,4 +84,22 @@ export class UpdateSiteDto {
   @IsNotEmpty()
   @MaxLength(100)
   readonly spotterApiToken?: string | null;
+
+  @ApiProperty({ example: 'deployed' })
+  @IsOptional()
+  @IsEnum(SiteStatus)
+  readonly status?: SiteStatus;
+
+  @IsOptional()
+  @Transform(({ value }) => {
+    return [true, 'true', 1, '1'].indexOf(value) > -1;
+  })
+  readonly display?: boolean;
+
+  @ApiProperty({ example: 'email: [email protected]' })
+  @IsOptional()
+  @IsString()
+  @IsNotEmpty()
+  @MaxLength(100)
+  readonly contactInformation?: string | null;
 }

packages/api/src/sites/sites.controller.ts

@@ -138,8 +138,9 @@ export class SitesController {
   update(
     @Param('siteId', ParseIntPipe) id: number,
     @Body() updateSiteDto: UpdateSiteDto,
+    @Req() request: AuthRequest,
   ): Promise<Site> {
-    return this.sitesService.update(id, updateSiteDto);
+    return this.sitesService.update(id, updateSiteDto, request.user);
   }
 
   @ApiBearerAuth()
@@ -196,4 +197,15 @@ export class SitesController {
   ): Promise<ExclusionDates[]> {
     return this.sitesService.getExclusionDates(id);
   }
+
+  @ApiBearerAuth()
+  @ApiOperation({
+    summary: 'Returns sites contact information notes',
+  })
+  @ApiParam({ name: 'siteId', example: 1 })
+  @Auth(AdminLevel.SuperAdmin)
+  @Get(':siteId/contact_info')
+  getContactInformation(@Param('siteId', ParseIntPipe) id: number) {
+    return this.sitesService.getContactInformation(id);
+  }
 }

packages/api/src/sites/sites.entity.ts

@@ -141,6 +141,11 @@ export class Site {
   @Column({ nullable: true, select: false, type: 'character varying' })
   spotterApiToken?: string | null;
 
+  @ApiHideProperty()
+  @Exclude()
+  @Column({ nullable: true, select: false, type: 'character varying' })
+  contactInformation?: string | null;
+
   hasHobo: boolean;
 
   collectionData?: CollectionDataDto;

packages/api/src/sites/sites.service.ts

@@ -4,6 +4,7 @@ import {
   Logger,
   BadRequestException,
   ConflictException,
+  ForbiddenException,
 } from '@nestjs/common';
 import { InjectRepository } from '@nestjs/typeorm';
 import { DataSource, Repository } from 'typeorm';
@@ -235,7 +236,21 @@ export class SitesService {
     };
   }
 
-  async update(id: number, updateSiteDto: UpdateSiteDto): Promise<Site> {
+  async update(
+    id: number,
+    updateSiteDto: UpdateSiteDto,
+    user: User,
+  ): Promise<Site> {
+    if (
+      (updateSiteDto.display ||
+        updateSiteDto.status ||
+        updateSiteDto.videoStream ||
+        updateSiteDto.contactInformation) &&
+      user.adminLevel !== AdminLevel.SuperAdmin
+    ) {
+      throw new ForbiddenException();
+    }
+
     const { coordinates, adminIds, regionId, streamId } = updateSiteDto;
     const updateRegion =
       regionId !== undefined ? { region: { id: regionId } } : {};
@@ -567,4 +582,15 @@ export class SitesService {
     // All checks passed, return video stream url.
     return site.videoStream;
   }
+
+  async getContactInformation(siteId: number) {
+    const { contactInformation } = await getSite(
+      siteId,
+      this.sitesRepository,
+      undefined,
+      true,
+    );
+
+    return { contactInformation };
+  }
 }

packages/api/src/sites/sites.spec.ts

@@ -222,7 +222,13 @@ export const siteTests = () => {
       expect(rsp.body.length).toBe(1);
 
       expect(rsp.body[0]).toMatchObject(
-        omit(floridaSite, 'createdAt', 'updatedAt', 'spotterApiToken'),
+        omit(
+          floridaSite,
+          'createdAt',
+          'updatedAt',
+          'spotterApiToken',
+          'contactInformation',
+        ),
       );
     });
 
@@ -242,6 +248,7 @@ export const siteTests = () => {
           'createdAt',
           'updatedAt',
           'spotterApiToken',
+          'contactInformation',
         ),
       );
     });

packages/api/src/users/users.spec.ts

@@ -130,10 +130,22 @@ export const userTests = () => {
       expect(rsp.status).toBe(200);
       expect(rsp.body.length).toBe(2);
       expect(rsp.body[0]).toMatchObject({
-        ...omit(californiaSite, 'updatedAt', 'createdAt', 'spotterApiToken'),
+        ...omit(
+          californiaSite,
+          'updatedAt',
+          'createdAt',
+          'spotterApiToken',
+          'contactInformation',
+        ),
       });
       expect(rsp.body[1]).toMatchObject({
-        ...omit(floridaSite, 'updatedAt', 'createdAt', 'spotterApiToken'),
+        ...omit(
+          floridaSite,
+          'updatedAt',
+          'createdAt',
+          'spotterApiToken',
+          'contactInformation',
+        ),
       });
     });
   });