fix(nvd): add support of versionStartExcluding and versionEndExcluding
#82
+64
−39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DmitriyLewen
commented
Apr 17, 2024
docGen/nvd.go
Outdated
| @@ -481,6 +480,22 @@ func parseVulnerabilityJSONFile(fileName string) (VulnerabilityPost, error) { | |||
| }, nil | |||
| } | |||
|
|
|||
| func detectVersion(includeVersion, excludeVersion, itemVersion string) string { | |||
There was a problem hiding this comment.
I used NVD logic ((including) and (excluding) suffixes).
Tell me if you see better way.
knqyf263
reviewed
Apr 17, 2024
|
There is still a mismatch for the 0.9.0-beta versions in the nist.gov source and the screenshot in the PR, see the last screenshot from this comment: aquasecurity/vuln-list-update#282 (comment) Edit: to clarify, I don't believe 0.9.0:beta4 and later is vulnerable. |
|
I don't know anything about the code, but the current screenshot in this PR looks like it captures everything from the CVE at nist.gov. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
versionStartExcludingandversionEndExcludingfields.(including)and(excluding)suffixes for versions.update(if used) for versions from CPEBefore:
After:
