-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GKE 1.6 CIS benchmark for GCP environment #1672
Merged
Merged
Changes from 11 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
50f4779
Add config entries for GKE 1.6 controls
ttousai 7794be3
Add gke1.6 control plane recommendations
ttousai 5c27cb2
Add gke-1.6.0 worker node recommendations
ttousai aee2710
Add gke-1.6.0 policy recommendations
ttousai 69222c1
Add managed services and policy recommendation
ttousai ebd34d5
Add master recommendations
ttousai f3e0d50
Fix formatting across gke-1.6.0 files
ttousai e96f308
Add gke-1.6.0 benchmark selection based on k8s version
ttousai e30c1e6
Workaround: hardcode kubelet config path for gke-1.6.0
ttousai ef1968b
Fix tests for makeIPTablesUtilChaings
ttousai ec9b88a
Merge branch 'main' into gke1.6
afdesk fcda8cf
Change scored field for all node tests to true
ttousai 0d13ece
Merge branch 'main' into gke1.6
afdesk 3d4ce59
Fix kubelet file permission to check for
ttousai File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| --- | ||
| ## Version-specific settings that override the values in cfg/config.yaml | ||
|
|
||
| node: | ||
| proxy: | ||
| defaultkubeconfig: "/var/lib/kubelet/kubeconfig" | ||
|
|
||
| kubelet: | ||
| defaultconf: "/etc/kubernetes/kubelet/kubelet-config.yaml" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| --- | ||
| controls: | ||
| version: "gke-1.6.0" | ||
| id: 2 | ||
| text: "Control Plane Configuration" | ||
| type: "controlplane" | ||
| groups: | ||
| - id: 2.1 | ||
| text: "Authentication and Authorization" | ||
| checks: | ||
| - id: 2.1.1 | ||
| text: "Client certificate authentication should not be used for users (Manual)" | ||
| type: "manual" | ||
| remediation: | | ||
| Alternative mechanisms provided by Kubernetes such as the use of OIDC should be | ||
| implemented in place of client certificates. | ||
|
|
||
| You can remediate the availability of client certificates in your GKE cluster. See | ||
| Recommendation 5.8.1. | ||
| scored: false | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this check marked as
automation.If there is no way to automate it, we should add a command to test in
remediationsection:$ kubectl get secrets --namespace kube-system # Look for secrets with names starting with gke-. These secrets contain the client certificates.