Map batch API #374
Merged
Map batch API #374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geyslan
force-pushed
the
map-batch
branch
2 times, most recently
from
44178a8
to
9008263
Compare
This breaks the API, returning a count of the number of elements processed for each batch method. It also fixes the check against ENOENT and E2BIG. The selftest has been updated to reflect the new API.
|
@rafaeldtinoco I got the other refactors in (were getting dust), but this breaks API. |
|
@rafaeldtinoco @geyslan We would love to be able to use batch APIs downstream @parca-dev. |
|
Hey @kakkoyun and @javierhonduco. We would love to get your review on this PR. |
Sure thing! 👍 |
|
Sorry for the delay on this. Going to merge as it is, any required changes are welcome. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close: #162
commit 9382e51 (HEAD -> map-batch, origin/map-batch)