chore(selftest): Add tc Query test case #422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chentao-kernel
force-pushed
the
dylane/tc
branch
from
b7bd38e
to
cbf8697
Compare
|
@chentao-kernel do you mind tackling in this same PR this other issue? #420 |
chentao-kernel
force-pushed
the
dylane/tc
branch
3 times, most recently
from
be0a5e6
to
91924f3
Compare
@geyslan hi, geyslan, i add the test case for #420, it seems the same cause with 421 |
chentao-kernel
force-pushed
the
dylane/tc
branch
3 times, most recently
from
1d3c72c
to
968c093
Compare
you mean issue #420 and #421 ？ actually，the test case mentioned in #420 #421 not correct, we should init the parameter first, you can see test case in linux source tools/testing/selftest/bpf/prog_tests/tc_bpf.c |
geyslan
reviewed
Apr 9, 2024
The bpf_tc_query/bpf_tc_detach interface should init the parameter first, sometimes it may be confused for us, so add the case to reduce the confusion. aquasecurity#421 aquasecurity#420 Signed-off-by: Tao Chen <[email protected]>
chentao-kernel
force-pushed
the
dylane/tc
branch
from
968c093
to
b872e29
Compare
|
Tks @chentao-kernel. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bpf_tc_query interface should init the parameter first, sometimes it may be confused for us, so add the test case to reduce the confusion.
Close: #421