feat(ksymbols): reintroduce lazy symbol queries #437
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Going on this soon. |
NDStrahilevitz
force-pushed
the
lazy_required_symbols
branch
from
5451945
to
3f00c64
Compare
Add new required symbol and addresses lists to the KSymbolTable helper. When either list is given, the data structure will only save required symbols during scanning. This should reduce memory usage for users who can mostly guarentee that symbols are known ahead of time. Dynamic querying is still allowed in this mode, though it will incur a penalty as rescanning is required.
NDStrahilevitz
force-pushed
the
lazy_required_symbols
branch
from
3f00c64
to
716c1f8
Compare
geyslan
approved these changes
May 29, 2024
| k.updateLock.RLock() | ||
| defer k.updateLock.RUnlock() | ||
| k.updateLock.Lock() | ||
| defer k.updateLock.Unlock() |
There was a problem hiding this comment.
As the goal is to squeeze as much as possible (optimise wise), what do you think unlocking right after the getTextSegmentAddresses() call?
| @@ -225,6 +308,13 @@ func (k *KernelSymbolTable) processLines(chans []chan *KernelSymbol) error { | |||
| continue | |||
| } | |||
| if sym := parseLine(fields); sym != nil { | |||
| if k.onlyRequired { | |||
There was a problem hiding this comment.
Can't we assume at this stage that if !k.onlyRequired we should continue?
| type name struct { | ||
| name string | ||
| } | ||
| type name string |
|
|
||
| symbols, exist := k.symbols[name{n}] | ||
| err := k.validateOrAddRequiredSym(name(n)) |
There was a problem hiding this comment.
What about returning symbols and exist from validateOrAddRequiredSym, so we could release the lock right after it returns checking them later.
|
Closing this in favour of aquasecurity/tracee#4095 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new required symbol and addresses lists to the KSymbolTable helper. When either list is given, the data structure will only save required symbols during scanning. This should reduce memory usage for users who can mostly guarentee that symbols are known ahead of time.
Dynamic querying is still allowed in this mode, though it will incur a penalty as rescanning is required.