chore(prog): Add attach/detach legacy api for xdp #438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geyslan
requested changes
Jun 6, 2024
prog.go
Outdated
Comment on lines
312
to
315
| optsC := &C.struct_bpf_xdp_attach_opts{ | ||
| sz: C.ulong(unsafe.Sizeof(C.struct_bpf_xdp_attach_opts{})), | ||
| old_prog_fd: 0, | ||
| } |
There was a problem hiding this comment.
Could you convert these instantiations to use the structure handlers pattern found in libbpfgo.h, since cgo has problems with structure packaging and field offsets? By instance:
- cgo_bpf_xdp_attach_opts_new
- cgo_bpf_xdp_attach_opts_free
prog.go
Outdated
Comment on lines
332
to
334
| optsC := &C.struct_bpf_xdp_attach_opts{ | ||
| sz: C.ulong(unsafe.Sizeof(C.struct_bpf_xdp_attach_opts{})), | ||
| old_prog_fd: C.int(p.FileDescriptor()), | ||
| } |
prog-common.go
Outdated
Comment on lines
51
to
63
| // XDPFlags | ||
| type XDPFlags uint32 | ||
|
|
||
| const ( | ||
| XDPFlagsUpdateIfNoExist XDPFlags = C.XDP_FLAGS_UPDATE_IF_NOEXIST | ||
| XDPFlagsSkbMode XDPFlags = C.XDP_FLAGS_SKB_MODE | ||
| XDPFlagsDrvMode XDPFlags = C.XDP_FLAGS_DRV_MODE | ||
| XDPFlagsHwMode XDPFlags = C.XDP_FLAGS_HW_MODE | ||
| XDPFlagsReplace XDPFlags = C.XDP_FLAGS_REPLACE | ||
| XDPFlagsModes XDPFlags = C.XDP_FLAGS_MODES | ||
| XDPFlagsMask XDPFlags = C.XDP_FLAGS_MASK | ||
| ) | ||
|
|
There was a problem hiding this comment.
Please move this block to the end of the file following the comment pattern.
Hi, geyslan, thank you for your reply, i will do it later! |
The AttachXDP api use bpf link to attach xdp prog, AttachXDPLegacy/DetachXDPLegacy apis corresponds to bpf_xdp_attach/bpf_xdp_detach, which can be used on old kernel, so add it. Signed-off-by: Tao Chen <[email protected]>
chentao-kernel
force-pushed
the
dylane/xdp2
branch
from
43a3f7d
to
b8df610
Compare
geyslan
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The AttachXDP api use bpf link to attach xdp prog, AttachXDPLegacy/DetachXDPLegacy apis corresponds to bpf_xdp_attach/bpf_xdp_detach, which can be used on old kernel, so add it.