Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(feat): improve probe bpf helper based on program type #447

Merged
merged 1 commit into from
Jul 11, 2024
Merged

chore(feat): improve probe bpf helper based on program type #447

merged 1 commit into from
Jul 11, 2024

Conversation

rscampos
Copy link
Collaborator

@rscampos rscampos commented Jul 2, 2024 •
edited
Loading

Create type BPFFunc in package libbpfgo in or to avoid import package helpers in libbpfgo.go.
Improve tests in order to use capabilities.

@rscampos rscampos self-assigned this Jul 2, 2024
@rscampos rscampos requested a review from geyslan July 2, 2024 20:36
geyslan
geyslan reviewed Jul 2, 2024
View reviewed changes
prog-common.go Show resolved Hide resolved
@rscampos rscampos force-pushed the chore_feat_probe_func_support branch 2 times, most recently from d9946ea to a923c7c Compare July 3, 2024 19:08
@rscampos rscampos force-pushed the chore_feat_probe_func_support branch 4 times, most recently from f960ff2 to 6a1d418 Compare July 11, 2024 13:48
geyslan
geyslan reviewed Jul 11, 2024
View reviewed changes
libbpfgo.go Outdated Show resolved Hide resolved
geyslan
geyslan previously approved these changes Jul 11, 2024
View reviewed changes
Copy link
Member

@geyslan geyslan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Good testing cases! Awesome.

I would only suggest an improved BPFHelperIsSupported comment.

@rscampos
chore(feat): probe bpf helper improve
f3a0d0d 
- create type BPFFunc in libbpfgo;
- improve tests with capabilities.
@rscampos rscampos force-pushed the chore_feat_probe_func_support branch from 6a1d418 to f3a0d0d Compare July 11, 2024 14:17
@rscampos
Copy link
Collaborator Author

Done, thank you for the review @geyslan

@rscampos rscampos requested a review from geyslan July 11, 2024 14:20
@rscampos rscampos changed the title chore(feat): create type BPFFunc in libbpfgo chore(feat): improve probe bpf helper based on program type Jul 11, 2024
@rscampos rscampos merged commit 73c0323 into aquasecurity:main Jul 11, 2024
17 checks passed
@rscampos rscampos mentioned this pull request Jul 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geyslan geyslan geyslan approved these changes

Assignees

@rscampos rscampos

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rscampos @geyslan