fix(events): fix process_execute_failed missing symbol for new kernels
#3983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/ebpf
kind/documentation
area/testing
area/events
area/build
labels
AlonZivony
force-pushed
the
bugfix/exec-failed-fast-fix
branch
2 times, most recently
from
23090de
to
0774240
Compare
AlonZivony
changed the title
process_execute_failed missing symbol for new kernels
|
Going over this today. 👍🏼 |
geyslan
reviewed
Apr 18, 2024
Fix an issue that usermode events are only created if they should be emitted.
The previous probe was missing from different distros and kernels. The new probes are safer, but only exist starting from v5.8 of the kernel.
AlonZivony
force-pushed
the
bugfix/exec-failed-fast-fix
branch
from
0774240
to
a496a9e
Compare
|
@geyslan if you can make sure this PR is getting into the 0.21 version it would be great. |
This one went unnoticed, sorry. We filter by kind/bug label to check if a PR needs to enter before the RC. Probably some issue or this PR did not have the label and this one was left out. But let's fix it. |
|
E2E 1483 green. |
|
Backport: #4011 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Explain what the PR does
Fix the
process_execute_failedevent missing probe error for kernel 5.8 forward.This is a quick fix, as it uses a global value to determine which probes to use.
In the future, it should be determined using the fallback mechanism - #3965.
This is the fast fix for the previous PR #3881.
Fix #3356
Also fix #3727 as this is the last step for it to be fixed.
On the way fix #4008
2. Explain how to test it
3. Other comments