-
Notifications
You must be signed in to change notification settings - Fork 416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
analyze: enable sigs consuming sigs #4327
base: main
Are you sure you want to change the base?
analyze: enable sigs consuming sigs #4327
Conversation
290c8ba
to
df98dfc
Compare
Analyze is emitting warnings due to sig of sigs loading lack.
I tested it again since I noticed you removed the recursive loading what made the initial behaviour stands. For each selected event that is a signature, analyze emits an error:
|
Weird, I haven't seen it in my test. Maybe because I checked with grep, let me see. |
7320464
to
b9522b5
Compare
Manually tested on both tracee-rules and analyze. |
b9522b5
to
a50e04b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
a50e04b
to
bb4d6f8
Compare
2578da6
to
6e2493a
Compare
This allows initializing signature to event data without importing eBPF initialization logic, which require specific compilation tags. Co-authored-by: Asaf Eitani <[email protected]>
Opportunistic refactor. Logic does not relate to eBPF and does relate to event data. Also allows importing this logic without importing eBPF related code.
Signatures consuming other signatures relied on the single binary reprocessing finding events into the pipeline. This did not occur in analyze mode. Introduce that mechanism so that it now works. Co-authored-by: Asaf Eitani <[email protected]>
6e2493a
to
df567eb
Compare
Waiting for a final review by @geyslan before merging. |
1. Explain what the PR does
df567eb fix(analyze): enable sigs consuming sigs
ad56d06 fix(findings): clone properties before rewriting
84ceba7 chore: move finding event conversion to a package
3b32997 chore: decouple sig init from init
df567eb fix(analyze): enable sigs consuming sigs
84ceba7 chore: move finding event conversion to a package
3b32997 chore: decouple sig init from init
2. Explain how to test it
Currently we have internal tests for it. Confirmed it was working using those.
3. Other comments
Resolve #4326