-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: run integration tests across multiple Trivy versions #343
Conversation
Hmm for some reason the tests timeout on my machine
|
@simar7 Another option is to use trivy binary and run tests in matrix for 3 versions: 0.57.1 (the version in which bundle v1 support was added), latest and canary. |
Signed-off-by: Nikita Pivkin <[email protected]>
a03633f
to
3ad7a55
Compare
"/testdata/examples", | ||
} | ||
|
||
trivy, err := testcontainer.RunTrivy(ctx, "aquasec/trivy:"+version, args, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to call Terminate()
on the testcontainers that we create to properly clean them up?
Signed-off-by: Nikita Pivkin <[email protected]>
This PR replaces the use of the Trivy package with testcontainers to run Trivy in integration tests, making it easier to work with different versions of Trivy.
verify-bundle.go
file, as the bundle is now built and used by Trivy directly in integration tests.