Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: scanjob.customVolumesMount is not applied to the Built-Job #2241

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

takutakahashi
Copy link

@takutakahashi takutakahashi commented Aug 27, 2024

Description

A value generated by range is pass-by-value and changes will not apply to original array.
Then I used an index to change the array values directly.

Related issues

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@CLAassistant
Copy link

CLAassistant commented Aug 27, 2024

CLA assistant check
All committers have signed the CLA.

@takutakahashi takutakahashi changed the title Fix: scanjob.customVolumesMount is not applied to the Built-Job fix: scanjob.customVolumesMount is not applied to the Built-Job Aug 27, 2024
@github-actions github-actions bot added the bug label Aug 27, 2024
@takutakahashi takutakahashi marked this pull request as ready for review August 27, 2024 14:40
@miklezzzz
Copy link

cmon, guys, we've got to get it merged

@takutakahashi
Copy link
Author

Hello, I desire this PR will get merged!
If some processes is needed, please tell me about I need to do for merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

scanJob.customVolumesMount is not applied to the generated Job
3 participants