Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Updated twitter icon #7772

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: Updated twitter icon #7772

wants to merge 3 commits into from
+8 −8

Conversation

sarthak-kumar-shailendra
Copy link

@sarthak-kumar-shailendra sarthak-kumar-shailendra commented Oct 20, 2024 •
edited
Loading

Description

The Twitter logo has been changed and hasn't been updated on the site. [Fixes #7771]
After changes
Screenshot 2024-10-20 at 10 26 35 PM

Related issues

Related PRs

  • #XXX
  • #YYY

Remove this section if you don't have related PRs.

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@CLAassistant
Copy link

CLAassistant commented Oct 20, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@sarthak-kumar-shailendra sarthak-kumar-shailendra changed the title Updated twitter icpon fix: Updated twitter icon Oct 20, 2024
@knqyf263 knqyf263 marked this pull request as draft October 21, 2024 09:05
@sarthak-kumar-shailendra sarthak-kumar-shailendra marked this pull request as ready for review October 21, 2024 14:23
@sarthak-kumar-shailendra
Copy link
Author

@knqyf263 Please review

@knqyf263 knqyf263 marked this pull request as draft October 29, 2024 02:18
@knqyf263
Copy link
Collaborator

The document is broken.
https://github.com/aquasecurity/trivy/actions/runs/11428059837/job/31805397696?pr=7772

@sarthak-kumar-shailendra sarthak-kumar-shailendra marked this pull request as ready for review October 29, 2024 08:59
@sarthak-kumar-shailendra
Copy link
Author

It was failing because of the old version of mkdocs-material.

@knqyf263 knqyf263 marked this pull request as draft October 29, 2024 09:34
@sarthak-kumar-shailendra sarthak-kumar-shailendra marked this pull request as ready for review October 29, 2024 17:16
@sarthak-kumar-shailendra
Copy link
Author

sarthak-kumar-shailendra commented Oct 31, 2024 •
edited
Loading

The document is broken.
https://github.com/aquasecurity/trivy/actions/runs/11428059837/job/31805397696?pr=7772

It's fixed now. @knqyf263

knqyf263
knqyf263 reviewed Oct 31, 2024
View reviewed changes
Copy link
Collaborator

@knqyf263 knqyf263 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing.
I think it's better to use the same version as the one in requirements.txt. here. I know there is a discrepancy now, though.

trivy/docs/build/Dockerfile

Line 1 in e872ec0

FROM squidfunk/mkdocs-material:9.4.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knqyf263 knqyf263 knqyf263 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sarthak-kumar-shailendra @CLAassistant @knqyf263