feat(secret): Add built-in secrets rules for Private Packagist #7826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Private Packagist (Packagist.com) is a package repository for Composer, the dependency manager for PHP. Private Packagist generates user and organization tokens for authentication. All tokens are generated with a prefix and a checksum to help with automated secret scanning. See https://packagist.com/docs/composer-authentication#token-format.
nicwortel
commented
Oct 30, 2024
| Category: CategoryPrivatePackagist, | ||
| Title: "Private Packagist user token", | ||
| Severity: "HIGH", | ||
| // https://packagist.com/docs/composer-authentication#token-format |
There was a problem hiding this comment.
I don't see any other comments referring to the documentation of the token format, but I thought it would be useful.
Let me know if I should remove it.
|
The Private Packagist token actually contains a checksum which can be calculated based on the prefix and random string, but as far as I'm aware Trivy doesn't support this, so I haven't implemented such a check. |
nicwortel
commented
Oct 30, 2024
| ID: "private-packagist-user-token", | ||
| Category: CategoryPrivatePackagist, | ||
| Title: "Private Packagist user token", | ||
| Severity: "HIGH", |
There was a problem hiding this comment.
I couldn't find any documentation on how to choose a severity level for secrets.
How should I determine the level?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Private Packagist is a package repository for Composer, the dependency manager for PHP. It allows businesses to publish private packages for consumption within their organization, mirror open-source packages, receive vulnerability alerts, etc.
Private Packagist generates user and organization tokens for authentication.
All tokens are generated with a prefix and a checksum to help with automated secret scanning.
See https://packagist.com/docs/composer-authentication#token-format.
This pull requests adds built-in rules for the tokens generated by Private Packagist so Trivy can detect them.
Related issues
None.
Checklist