Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Ensure constant format strings in fmt and printf calls #8258

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mikelolasagasti
Copy link

Go 1.24 introduces stricter checks for format string validation. This commit fixes instances where non-constant format strings were used in calls to functions like fmt.Errorf, fmt.Printf, and similar.

$ go version
go version go1.24rc2 linux/amd64

$ go vet -printf ./...
(...)
pkg/iac/scanners/terraform/parser/funcs/collection.go:512:48: non-constant format string in call to github.com/zclconf/go-cty/cty/function.NewArgErrorf
pkg/iac/scanners/terraform/parser/funcs/crypto.go:178:64: non-constant format string in call to github.com/zclconf/go-cty/cty/function.NewArgErrorf

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

Go 1.24 introduces stricter checks for format string validation.
This commit fixes instances where non-constant format strings were
used in calls to functions like `fmt.Errorf`, `fmt.Printf`, and similar.

Signed-off-by: Mikel Olasagasti Uranga <[email protected]>
@CLAassistant
Copy link

CLAassistant commented Jan 20, 2025

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@mikelolasagasti
Copy link
Author

Not sure what's going on with CLAassistant, but as first comment says it's signed ¯\(ツ)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants