Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: use require.ErrorContains when possible #8291

Merged
merged 1 commit into from
Jan 27, 2025
Merged

chore: use require.ErrorContains when possible #8291

merged 1 commit into from
Jan 27, 2025

Conversation

mmorel-35
Copy link
Contributor

@mmorel-35 mmorel-35 commented Jan 24, 2025 •
edited
Loading

Description

use require.ErrorContains instead of require.Error with assert.Contains when possible

@mmorel-35 mmorel-35 changed the title chore(test): use require.ErrorContains when possible chore: use require.ErrorContains when possible Jan 24, 2025
@mmorel-35 mmorel-35 marked this pull request as ready for review January 24, 2025 14:03
knqyf263
knqyf263 reviewed Jan 27, 2025
View reviewed changes
Copy link
Collaborator

@knqyf263 knqyf263 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also fixed it when we noticed it, but you did a great job fixing all of them once. Thank you so much.
I left one comment.

pkg/fanal/analyzer/analyzer_test.go Outdated Show resolved Hide resolved
@knqyf263 knqyf263 enabled auto-merge January 27, 2025 06:34
@knqyf263 knqyf263 added this pull request to the merge queue Jan 27, 2025
Merged via the queue into aquasecurity:main with commit 715575d Jan 27, 2025
12 checks passed
@mmorel-35 mmorel-35 deleted the error-contains branch January 27, 2025 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knqyf263 knqyf263 knqyf263 approved these changes

@DmitriyLewen DmitriyLewen Awaiting requested review from DmitriyLewen DmitriyLewen is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mmorel-35 @knqyf263