Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(misconf): Add support for aws_ami #8499

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

simar7
Copy link
Member

@simar7 simar7 commented Mar 6, 2025

Description

Related issues

  • Close #XXX

Related PRs

  • #XXX
  • #YYY

Remove this section if you don't have related PRs.

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).


import iacTypes "github.com/aquasecurity/trivy/pkg/iac/types"

type AMI struct {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The AMI is related to EC2, so I think it should be in the ec2 package as a field of the EC2 structure.
The aws_ami data source searches the image against the criteria and returns the id of an already registered AMI, while the resource creates the AMI. The owners field is only specific to the data source and if in the future we want to add checks for the resource, we will need to distinguish between the data source and the resource. Should we rename this structure to something like RequestedAMI (first thing that came to mind)?
Also, there may be multiple AMI data sources declared in the configuration , so this field should be a list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants