Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enqueuing playlists: skip songs that cannot be added #243

Merged
merged 2 commits into from
Aug 19, 2023

Conversation

jheuel
Copy link
Contributor

@jheuel jheuel commented Jun 20, 2023

This pull request changes the behaviour when enqueuing playlists. If there is a problem while enqueuing a track of a playlist the problematic song is skipped instead of canceling the whole process.
Also the mask for playlists in the YouTube::extract function was changed to match more playlist links.

@joao-conde
Copy link
Collaborator

Thanks for the contribution @jheuel

I think it makes perfect sense to try to enqueue the other songs.

@joao-conde joao-conde self-assigned this Aug 18, 2023
@joao-conde joao-conde self-requested a review August 18, 2023 23:53
@joao-conde joao-conde added the 🔧 improvement General improvements to existing features label Aug 18, 2023
@joao-conde joao-conde merged commit d13c701 into aquelemiguel:main Aug 19, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔧 improvement General improvements to existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants