Wrapper: hotfix isForwarder() check on apps #372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
isForwarder()check on each app was broken from theweb3@1upgrade (see underlying issue). This hotfixes the check so that we override it to befalseif the app wasn't compiled withIForwarder.Note that this isn't 100% full-proof; an app could, within reason, dynamically decide to start or stop being a forwarder at one point or another. Also note that having every app be a forwarder should not break anything, it just makes the transaction pathing algorithm more complicated and resource intensive.
Given that no app (that I know of) dynamically switches from being a forwarder to not, I sided with not degrading transaction pathing performance.