Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(APP-3954): Update Tab component to not render the TabList when there is a single child #407

Merged
merged 12 commits into from
Feb 18, 2025
Merged

feat(APP-3954): Update Tab component to not render the TabList when there is a single child #407

merged 12 commits into from
Feb 18, 2025
+52 −17

Conversation

shan8851
Copy link
Contributor

@shan8851 shan8851 commented Feb 15, 2025 •
edited by jira bot
Loading

Description

Update Tab component to not render the TabList when there is a single child

Task: APP-3954

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • Manually smoke tested the functionality locally
  • Confirmed there are no new warnings or errors in the browser console
  • Made the corresponding changes to the documentation
  • Added tests that prove my fix is effective or that my feature works
  • Updated the CHANGELOG.md file after the [UPCOMING] title and before the latest version
  • Confirmed there are no new warnings on automated tests
  • Selected the correct base branch
  • Commented the code in hard-to-understand areas
  • Followed the code style guidelines of this project
  • Reviewed that the files changed in GitHub’s UI reflect my intended changes
  • Confirmed the pipeline checks are not failing

@shan8851 shan8851 requested a review from a team February 15, 2025 20:41
cgero-eth
cgero-eth reviewed Feb 17, 2025
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
src/core/components/tabs/tabsTrigger/tabsTrigger.test.tsx Outdated Show resolved Hide resolved
src/core/components/tabs/tabsList/tabsList.tsx Outdated Show resolved Hide resolved
src/core/components/tabs/tabsRoot/tabsRoot.stories.tsx Outdated Show resolved Hide resolved
src/core/components/tabs/tabsList/tabsList.test.tsx Outdated Show resolved Hide resolved
src/core/components/tabs/tabsList/tabsList.test.tsx Outdated Show resolved Hide resolved
@shan8851 shan8851 requested a review from cgero-eth February 17, 2025 12:33
@shan8851 shan8851 requested a review from cgero-eth February 17, 2025 16:04
@cgero-eth cgero-eth merged commit 236b7e6 into main Feb 18, 2025
3 checks passed
@cgero-eth cgero-eth deleted the feat/app-3954 branch February 18, 2025 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgero-eth cgero-eth Awaiting requested review from cgero-eth

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shan8851 @cgero-eth