Deploy/mode upgrade v2 #61
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Static env files
feat: migration functionality
novaknole
reviewed
Feb 20, 2025
| ///////////////////////////////////////////// | ||
|
|
||
| ///////////////////////////////////////////// | ||
|
|
There was a problem hiding this comment.
I'd put vm.envString("NETWORK"), vm.envAddress("FACTORY_ADDRESS"), vm.envAddress("SIGNER_ADDRESS") as internal variables here. It lets us immediatelly see what env variables are needed.
novaknole
reviewed
Feb 20, 2025
| address voterImplNew = voterMode.implementation(); | ||
| address voterBPTImplNew = voterBPT.implementation(); | ||
|
|
||
| assertNotEq(voterImplOld, voterImplNew); |
There was a problem hiding this comment.
I'd probably add assertEq as well to check that the current implementation on the contracts are equal to the ones deployed in buildActions contract.
xavikh
reviewed
Feb 20, 2025
There was a problem hiding this comment.
Shouldn't the name be Mode-100-to-110.s.sol?
| } | ||
| function _buildMsigProposal( | ||
| IDAO.Action[] memory _actions, | ||
| address[] memory _signers, |
| function _startBroadcastOrPrank(bool isTestMode) internal { | ||
| address signer = vm.envAddress("SIGNER_ADDRESS"); | ||
| if (isTestMode) { | ||
| vm.startPrank(signer); |
There was a problem hiding this comment.
Is there a situation where this signer won't be an Aragon signer? Could we use aragonSigner[0]?
| bytes ipfsURI = bytes("ipfs://bafkreicqy5hgf6izqha6hoa6cudup4or5clfnilegyavwuhbr34xlihsea"); | ||
|
|
||
| function setAragonSigners() internal { | ||
| aragonSigners.push(address(0x946138B088524414EEDaf0699BA10d7Fb5673A34)); |
There was a problem hiding this comment.
What are your thoughts on moving this to a file similar to the Mode signers?
xavikh
reviewed
Feb 20, 2025
| // alice tries to exit | ||
| vm.startPrank(alice); | ||
| { | ||
| // vm.expectRevert(VotingInactive.selector); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.