docs: add kitajs/html example and tests #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome work!
Released at v4.0.0-next.3 |
|
Should the CI be fixed with v4.0.0-next.3 or it's something else kitajs should fix? |
|
@arthurfiorette by upgrading the version already pass the pipeline tests 🥳 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to kitajs/html#159
@arthurfiorette indeed the tests and example works, but I had to make a monkey-patch adding the jsx-dev-runtime as a copy of jsx-runtime and rename jsx to jsxDEV, probably a necessary change in kitajs/html to support it. For the moment I leave the PR and don't merge it until the new version with this change is ready.