Improved edit message interface #1514
Open
+34
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ayaan-qadri is attempting to deploy a commit to the Arc53 Team on Vercel. A member of the Team first needs to authorize it. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1514 +/- ##
=======================================
Coverage 35.51% 35.51%
=======================================
Files 73 73
Lines 3644 3644
=======================================
Hits 1294 1294
Misses 2350 2350 ☔ View full report in Codecov by Sentry. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ayaan-qadri
force-pushed
the
Fixing-1513
branch
from
7eaf4fd to
e327ef2
Compare
|
Just rebase for change commit message |
ManishMadan2882
requested changes
Jan 6, 2025
There was a problem hiding this comment.
Thanks @ayaan-qadri
Few points on this PR
- The update button should be rounded (as before) to match the design.
- The edit button shifts to bottom on selecting the edit option, make sure that it is positioned on the left as in the main version.
|
@ManishMadan2882 It is useless to show edit button when it is already in edit mode & made button as it was before (rounded-full) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved edit message interface and decreased right margin hover on message button
Fixes - 🐛 Bug Report: Edit message interface should be improved #1513
Before
After