Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update arches applications example #449

Merged
merged 1 commit into from
Jul 19, 2024
Merged

Conversation

jacobtylerwalls
Copy link
Member

brief description of changes

Catch up with changes from archesproject/arches#11016 that removed the ARCHES_APPLICATIONS setting.

This box must be checked

  • the PR branch was originally made from the base branch

This box should be checked

  • after these changes the docs build locally without error

This box should only be checked you intend to follow through on it (we can do it on our end too)

  • I will cherry-pick all commits in this PR into other branches that should have them after this PR is merged

@@ -45,65 +45,57 @@ Installing the **Arches Dashboard** App
---------------------------------------
You can add the dashboard to an Arches project in just a few easy steps.

1. Install if from this repo (or clone this repo and pip install it locally).

1. Install it from this repo (or clone this repo and pip install it locally):
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The whitespace changes are to avoid the extra level of nesting that was appearing:

Screenshot 2024-07-19 at 3 28 52 PM

Now:
Screenshot 2024-07-19 at 3 29 17 PM

I think the added bolding is a bug fixed in more recent versions of Sphinx. Don't know what version we're using to build the live site.



3. Add routing to your project to handle the Arches application. This can be either subdomain routing or path-based routing.
- for subdomain routing:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Standardized the indentation

@jacobtylerwalls jacobtylerwalls requested a review from ekansa July 19, 2024 19:33
@ekansa
Copy link
Collaborator

ekansa commented Jul 19, 2024

Thanks @jacobtylerwalls ! LGTM!

@ekansa ekansa merged commit adca540 into master Jul 19, 2024
@jacobtylerwalls jacobtylerwalls deleted the master_arches_applications_update branch July 19, 2024 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants